Skip to content

llm: Add plan-implement-review pipeline command - #7121

Open
SaintPatrck wants to merge 1 commit into
mainfrom
llm/plan-implement-review-command
Open

llm: Add plan-implement-review pipeline command#7121
SaintPatrck wants to merge 1 commit into
mainfrom
llm/plan-implement-review-command

Conversation

@SaintPatrck

Copy link
Copy Markdown
Contributor

Objective

Add a plan-implement-review command that orchestrates an end-to-end Android development pipeline — requirements analysis, architecture planning, implementation, and multi-agent code review — driven by a Claude Code agent team.

Pipeline

  • Plan (once): Requirements → Architecture → Work Breakdown → QA Handoff
  • Implement + Review (per phase): implement → 4-reviewer gauntlet → up-to-3-round fix cycle
  • Reviewer roles map to Bitwarden marketplace agents (product-analyst, architect, security-engineer, code-reviewer, software-engineer).

Notes

  • Requires CLAUDE_CODE_EXPERIMENTAL_AGENT_TEAMS=1.
  • Targets the implicit agent-team model (Claude Code v2.1.178+): teammates are spawned via the Agent tool and team setup/teardown is automatic — no TeamCreate/TeamDelete.

@github-actions github-actions Bot added the t:llm Change Type - LLM related change (e.g. CLAUDE.md files) label Jun 30, 2026
@codecov

codecov Bot commented Jun 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.86%. Comparing base (4d6c8c4) to head (2df725c).
⚠️ Report is 86 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7121   +/-   ##
=======================================
  Coverage   85.86%   85.86%           
=======================================
  Files         926      926           
  Lines       65940    65940           
  Branches     9376     9376           
=======================================
  Hits        56617    56617           
  Misses       6098     6098           
  Partials     3225     3225           
Flag Coverage Δ
app-data 17.21% <ø> (ø)
app-ui-auth-tools 18.84% <ø> (ø)
app-ui-platform 16.53% <ø> (ø)
app-ui-vault 28.34% <ø> (ø)
authenticator 6.16% <ø> (ø)
lib-core-network-bridge 4.05% <ø> (ø)
lib-data-ui 1.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@SaintPatrck
SaintPatrck marked this pull request as ready for review August 7, 2026 17:55
@SaintPatrck
SaintPatrck requested a review from a team as a code owner August 7, 2026 17:55
@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

This PR adds a single new slash command, .claude/commands/plan-implement-review.md (304 lines), which orchestrates an agent-team pipeline covering requirements analysis, architecture planning, phased implementation, and a four-reviewer gauntlet with a bounded fix cycle. No application code, dependencies, or settings files are touched, so there is no runtime or supply-chain risk. Frontmatter (description, argument-hint) matches the conventions of the existing plan-android-work, work-on-android, and review-android commands, and the referenced agent identifiers resolve against the installed marketplace plugins. Two documentation-consistency items were found; neither blocks merge.

Code Review Details
  • ♻️ : Consolidated review summary path is not phase/round-scoped, so it is overwritten each cycle while reviewer output files are correctly scoped — Step 7 then references artifacts that no longer exist
    • .claude/commands/plan-implement-review.md:188
  • ♻️ : New command is not registered in the .claude/CLAUDE.md command table
    • .claude/commands/plan-implement-review.md:3

Also noted, not raised inline: Step 7 suggests Skill(bitwarden-delivery-tools:creating-pull-request) but bitwarden-delivery-tools is absent from the Prerequisites table.

After all 4 review tasks for a phase are complete, **you (the team lead) consolidate** the findings:

1. Read all 4 review output files.
2. Write a consolidated review summary to `.claude/outputs/reviews/{slug}-REVIEW-SUMMARY.md`:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

♻️ DEBT: Consolidated summary path is not phase/round-scoped, so it is overwritten every cycle.

Details and fix

Step 3b scopes reviewer outputs per phase ({slug}-REVIEW-CODE-P{N}.md), and Step 6b explicitly overwrites per round. But Step 5 always writes to the same fixed {slug}-REVIEW-SUMMARY.md, even though the template inside it carries **Phase** and **Round** fields.

For a multi-phase run (which Step 3 calls "the norm"), the final artifact only contains the last round of the last phase. Step 7 then promises to present "Consolidated review summary path" and "Number of review-fix cycles per phase" from artifacts that no longer exist.

Suggested fix — scope the path the same way reviewer files are:

2. Write a consolidated review summary to `.claude/outputs/reviews/{slug}-REVIEW-SUMMARY-P{N}-R{round}.md`:

and update the Step 1 output-path list to match.

@@ -0,0 +1,304 @@
---
description: End-to-end pipeline orchestrating requirements analysis, architecture planning, implementation, and multi-agent code review via agent team
argument-hint: <task description, Jira ticket, or Confluence URL> [--confirm]

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

♻️ DEBT: New command is not registered in the .claude/CLAUDE.md command table.

Details and fix

.claude/CLAUDE.md maintains a Command registry that currently lists /plan-android-work, /work-on-android, and /review-android. Adding a command without a corresponding row makes it undiscoverable to anyone reading the project config, and leaves the table stale for the next contributor.

Suggested addition to the Command table in .claude/CLAUDE.md:

| `/plan-implement-review <task>` | Agent-team pipeline: plan → implement → 4-reviewer gauntlet → fix cycle (requires `CLAUDE_CODE_EXPERIMENTAL_AGENT_TEAMS=1`) |

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t:llm Change Type - LLM related change (e.g. CLAUDE.md files)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant