script: allow hyphens in deputy email domains - #2283
Merged
murchandamus merged 1 commit intoSep 11, 2026
Conversation
murchandamus
approved these changes
Sep 11, 2026
murchandamus
left a comment
murchandamus
left a comment
Member
There was a problem hiding this comment.
ACK afc982a. Good catch, thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BIP 3 specifies that the Deputies header uses the same format as the Authors header, but buildtable.pl currently validates them with slightly different domain patterns.
Authors accepts hyphens in domain names, while the generic email-field check used by Deputies and legacy Editor fields does not. As a result, a valid address such as alice@bitcoin-dev.org is accepted for an author but rejected for a deputy.
This change allows hyphens in the generic email domain matcher as well, keeping the validation consistent with the Authors format.