bip174: add combiner test vector for PSBT_IN_SIGHASH_TYPE - #2275
Open
Sjors wants to merge 2 commits into
Open
Conversation
The Combiner section is updated to say combining is commutative unless the PSBTs have conflicting fields. None of the current combiner test vectors contain such fields.
This was referenced Sep 4, 2026
murchandamus
added
Proposed BIP modification
achow101
reviewed
Sep 9, 2026
achow101
reviewed
Sep 9, 2026
Add a vector where only one of the two PSBTs has the PSBT_IN_SIGHASH_TYPE field. See bitcoin/bitcoin#36076
Sjors
force-pushed
the
2026/09/psbt-sighash
branch
from
September 10, 2026 06:43
1399ae4 to
0bae693
Compare
Member
Author
|
Trimmed the text and just copy-pasted both PSBTs, instead of trying to point to them (the vectors are not numbered or named). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a vector that would have caught bitcoin/bitcoin#36076.
Additionally, #2075 clarified that
Combineis not commutative, however the actual test vectors are. The first commit clarifies that the existing test vectors should be run in both orders, while leaving room for exceptions if we ever need to standardize conflict resolution.