Skip to content

README update for VDuda v3 update #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Bobspadger wants to merge 8 commits into
base: master
Choose a base branch
from
Open

README update for VDuda v3 update #86

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
332c853
add in variants and v3 ability as per https://github.com/bigcommerce/…
Bobspadger Jul 9, 2019
924d791
README for using the v3 mod.
Bobspadger Jul 9, 2019
c71d4a6
DIRTY HACK TO MAKE ORDERS WORK ON v3
Bobspadger Aug 12, 2019
f79b8c4
Merge pull request #2 from Bobspadger/fix-orders-v2
Bobspadger Aug 12, 2019
2399e0f
Revert "DIRTY HACK TO MAKE ORDERS WORK ON v3"
Bobspadger Aug 21, 2019
fd8c7e3
Merge pull request #4 from Bobspadger/fix-orders-v2
Bobspadger Aug 21, 2019
7cc44dd
Revert "Revert "DIRTY HACK TO MAKE ORDERS WORK ON v3""
Bobspadger Aug 21, 2019
c5c36ce
Merge pull request #5 from Bobspadger/fix-orders-v2
Bobspadger Aug 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion bigcommerce/connection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,10 @@ def _run_method(self, method, url, data=None, query=None, headers=None):

# Support v3
if self.api_path and 'v3' in self.api_path:
url = 'catalog/{}'.format(url)
if url is 'orders':
Copy link
Copy Markdown

@ThePsyjo ThePsyjo Oct 2, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will never be True, use == instead of is.

self.api_path = self.api_path.replace('v3', 'v2')
else:
url = 'catalog/{}'.format(url)

# make full path if not given
if url and url[:4] != "http":
Expand Down