fix: preserve volume blocks and render menu text - #783
Conversation
|
Leaving this draft unmerged for now. The code changes and focused regression coverage look sound, and CI is green, but the PR explicitly identifies the same-state BasiliskII Controls-dialog comparison as still pending. Please complete that comparison, update the validation notes with the result, and mark the PR ready for review when the compatibility claim is supported. |
|
This remains correctly unmerged. In addition to the pending same-state BasiliskII Controls-dialog comparison already noted, it now conflicts with current master in the framebuffer path after substantial menu/window/runtime changes. Once the oracle comparison is complete, please rebase and resolve against current master, verify that each remaining change is not already covered by later work, rerun the focused classic/HFS trap tests and deterministic route, and then mark it ready. #782 should remain open in the meantime. |
Summary
PBGetVInfoparameter block while continuing to populate the extended HFS fields forPBHGetVInfoReferences
Validation
cargo test --lib: 3,879 passed, 0 failed, 3 ignoredPBGetVInfotests: 3 passedPBHGetVInfotests: 9 passedDraft status
The Controls dialog itself renders correctly, but the current deterministic BasiliskII interaction reaches it from a different application state (or misses menu tracking), so a strict same-state application-window comparison is still pending. This draft intentionally does not claim the full compatibility matrix is complete.
Closes #782