feat(theme): experiment with Systemless guest chrome - #1362
Conversation
|
Heads-up: while re-baselining perf work against current With the default |
|
Follow-up: the fix is #1421. Themed dialog frames, the menu bar and menu titles are rendered once per distinct input and replayed from resolved device pixel indices; pixel output is identical (the paired replays check the framebuffer hash on every pair). Bisect put this PR at +40 B host instructions on the 3 in Three replay (268.0 B → 308.6 B); #1421's two steps measure −17.8% (with #1420) and −4.9% on that replay, and −14.6% and −9.0% on SimCity 2000. All regression fixes together (#1419, #1420, #1421 on top of #1220): −53.0% CPU time on 3 in Three, −30.8% on SimCity 2000, machine idle. |
Summary
systemless-defaultthe normal 68K guest chrome in both the library runner and desktop commandclassic-system7available through--ui-theme classic-system7for compatibility and original reference snapshots#15130f,#c9b183,#2794c4,#dff6ff) while preserving classic Macintosh window/control geometry and metricsThe themed presentation currently targets the 68K HLE chrome. Native PowerPC guest chrome remains classic until the shared provider is threaded through that adapter.
Visual review
Browse all 43 themed Toolbox Showcase frames
Verification
cargo check --lib --bin systemlesscargo test --lib --features test-support— 4,915 passed, 3 ignoredcargo test --bin systemless cli_— 8 passedcargo test --locked --test toolbox_showcase— classic 68K 43-frame baselineSYSTEMLESS_PREFER_POWERPC=1 cargo test --locked --test toolbox_showcase— classic PowerPC gallerySYSTEMLESS_TOOLBOX_THEME=systemless-default cargo test --locked --test toolbox_showcase— Systemless 43-frame galleryCloses #1361