Skip to content

Add new algorithm: SPABA SFFBA and MSEBA#47

Open
SUSTech-Optimization wants to merge 6 commits intobenchopt:mainfrom
SUSTech-Optimization:main
Open

Add new algorithm: SPABA SFFBA and MSEBA#47
SUSTech-Optimization wants to merge 6 commits intobenchopt:mainfrom
SUSTech-Optimization:main

Conversation

@SUSTech-Optimization
Copy link
Copy Markdown

We have added three new algorithms: SPABA (Chu et al., ICML 2024), SFFBA, and MSEBA. For further details, refer to the $\texttt{spaba.py}$, $\texttt{sffba.py}$, and $\texttt{mseba.py}$ files located in the $\texttt{solver}$ folder. Additionally, we have updated the optimal parameter selection for these algorithms, and the corresponding files can be found in the $\texttt{config}$ folder.

Added three algorithms SFFBA SPABA and MSEBA in the solver folder
Added the optimal hyperparameters of the three algorithms SFFBA SPABA and MSEBA in the config file
dd three algorithms SFFBA SPABA and MSEBA in the solver folder
Add three algorithms SFFBA SPABA and MSEBA in the solver folder
Copy link
Copy Markdown
Member

@tomMoral tomMoral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello!

thanks a lot for the PR!
I mostly have a few comments on the form, and a few questions to understand well the algorithms.

It mostly looks good to me but I just want to add extra info to make it easy to understand where the difference are.

Comment thread config/covtype_best_params.yml Outdated
Comment thread config/datacleaning0_5_best_params.yml Outdated
Comment thread config/datacleaning0_7_best_params.yml Outdated
Comment thread config/datacleaning0_9_best_params.yml Outdated
Comment thread config/ijcnn1_best_params.yml Outdated
Comment thread solvers/sffba.py Outdated
Comment thread solvers/sffba.py Outdated
Comment thread solvers/sffba.py
Comment thread solvers/mseba.py Outdated
Comment thread solvers/mseba.py Outdated
@SUSTech-Optimization
Copy link
Copy Markdown
Author

We appreciate your suggestions regarding our code. If you have any questions, please feel free to contact us. We wish you all the best.

@SUSTech-Optimization
Copy link
Copy Markdown
Author

Hi, I hope everything is going well. I would like to kindly follow up on this PR. If you have any suggestions or thoughts regarding our algorithms, please don’t hesitate to let us know — your feedback would be greatly appreciated. We sincerely appreciate your outstanding work and have been very interested in it. We also have some related research in progress, and if possible, we would be delighted to stay in touch and explore opportunities for long-term collaboration. Please let me know if there are any updates or if any further adjustments are needed. Thank you very much for your time and consideration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants