Skip to content

Filter out zero penalty for cli display#6556

Merged
snejus merged 4 commits intobeetbox:masterfrom
matthiasdv:mdv/fix-penalty-display
Apr 21, 2026
Merged

Filter out zero penalty for cli display#6556
snejus merged 4 commits intobeetbox:masterfrom
matthiasdv:mdv/fix-penalty-display

Conversation

@matthiasdv
Copy link
Copy Markdown
Contributor

Description

Fixes #6555

generic_penalty_keys at beets/autotag/distance.py:145 returns all keys in _penalties without filtering for non-zero values.

I think this is a regression.

To Do

  • Documentation
  • Changelog
  • Tests

@matthiasdv matthiasdv requested a review from a team as a code owner April 20, 2026 14:00
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.76%. Comparing base (b13a4fa) to head (e474194).
⚠️ Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6556   +/-   ##
=======================================
  Coverage   71.75%   71.76%           
=======================================
  Files         159      159           
  Lines       20515    20515           
  Branches     3262     3262           
=======================================
+ Hits        14721    14722    +1     
  Misses       5105     5105           
+ Partials      689      688    -1     
Files with missing lines Coverage Δ
beets/autotag/distance.py 83.52% <ø> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JOJ0
Copy link
Copy Markdown
Member

JOJ0 commented Apr 20, 2026

run poe format-docs to fix the failing pipeline lint check

Copy link
Copy Markdown
Member

@snejus snejus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, thank you!

@snejus snejus merged commit 406db7c into beetbox:master Apr 21, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CLI incorrectly marks diff in tags (regression)

3 participants