Skip to content

Fix script issues #3577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gravitacia wants to merge 2 commits into from
+13 −6
Closed

Fix script issues #3577

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9062663
Fix script issues
gravitacia May 31, 2026
ef68a45
Merge branch 'master' into fix-scripts
zinduolis Jun 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions install
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,8 +138,8 @@ install_linux() {
sudo pacman -S ruby ruby-rdoc
fi
elif [ "${Distro}" = "Alpine" ]; then
apk update
apk add curl git build-base openssl readline-dev zlib zlib-dev libressl-dev yaml-dev sqlite-dev sqlite libxml2-dev libxslt-dev autoconf libc6-compat ncurses5 automake libtool bison nodejs
sudo apk update
sudo apk add curl git build-base openssl readline-dev zlib zlib-dev libressl-dev yaml-dev sqlite-dev sqlite libxml2-dev libxslt-dev autoconf libc6-compat ncurses5 automake libtool bison nodejs
fi
}

Expand Down
15 changes: 11 additions & 4 deletions tools/bump-version.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,17 @@ fi
echo "Updating version ${1} to ${2}"

git checkout -b "release/${2}"
sed -i '' -e "s/$1/$2/g" VERSION
sed -i '' -e "s/\"version\": \"$1\"/\"version\": \"$2\"/g" package.json
sed -i '' -e "s/\"version\": \"$1\"/\"version\": \"$2\"/g" package-lock.json
sed -i '' -e "s/\"version\": \"$1\"/\"version\": \"$2\"/g" config.yaml
if [[ "$OSTYPE" == "darwin"* ]]; then

@zinduolis zinduolis Jun 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gravitacia , what are your thoughts on making this more robust across all Unix-like operating systems and shell environment as per below?

if sed --version 2>&1 | grep -q 'GNU'; then
  # GNU sed
  sed -i -e "s/$1/$2/g" VERSION
  sed -i -e "s/\"version\": \"$1\"/\"version\": \"$2\"/g" package.json
  sed -i -e "s/\"version\": \"$1\"/\"version\": \"$2\"/g" package-lock.json
  sed -i -e "s/\"version\": \"$1\"/\"version\": \"$2\"/g" config.yaml
else
  # BSD sed (macOS, FreeBSD, OpenBSD, etc.)
  sed -i '' -e "s/$1/$2/g" VERSION
  sed -i '' -e "s/\"version\": \"$1\"/\"version\": \"$2\"/g" package.json
  sed -i '' -e "s/\"version\": \"$1\"/\"version\": \"$2\"/g" package-lock.json
  sed -i '' -e "s/\"version\": \"$1\"/\"version\": \"$2\"/g" config.yaml
fi

@gravitacia gravitacia Jun 2, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I think it will be better that way

@zinduolis zinduolis Jun 8, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update your PR, test it and let me know when I can review it again.

sed -i '' -e "s/$1/$2/g" VERSION
sed -i '' -e "s/\"version\": \"$1\"/\"version\": \"$2\"/g" package.json
sed -i '' -e "s/\"version\": \"$1\"/\"version\": \"$2\"/g" package-lock.json
sed -i '' -e "s/\"version\": \"$1\"/\"version\": \"$2\"/g" config.yaml
else
sed -i -e "s/$1/$2/g" VERSION
sed -i -e "s/\"version\": \"$1\"/\"version\": \"$2\"/g" package.json
sed -i -e "s/\"version\": \"$1\"/\"version\": \"$2\"/g" package-lock.json
sed -i -e "s/\"version\": \"$1\"/\"version\": \"$2\"/g" config.yaml
fi

git add VERSION package.json package-lock.json config.yaml
git commit -m "Version bump ${2}"
Expand Down