Support extensions triggering file import#2285
Open
mescanne wants to merge 1 commit into
Open
Conversation
mescanne
force-pushed
the
feature/import-extract-hash
branch
from
29e7742 to
f754dc7
Compare
Adds a globally hoisted `<GlobalExtract>` modal that triggers on the URL hash pattern `#extract?filename=...&importer=...`. This allows third-party extensions to trigger Fava's native ML extraction and `ExtractFeed` review UI as a pure overlay without navigating away from their current dashboard context. The loading state is delegated to Fava's global `loading_state.await()`, keeping the PR focused and inheriting generic UI loading enhancements natively.
mescanne
force-pushed
the
feature/import-extract-hash
branch
from
f754dc7 to
7cf0884
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This functionality enables extensions to trigger a normal file import process. (for reference - https://github.com/mescanne/beancount-blue)
Background:
I'm building an extension to enable API-driven sync and imports. I'm using the standard Beancount and Fava file import pattern (where files contain configuration and do not move) and would like to leverage Fava's normal import process, but not import screen. Another PR will be raised to cover bulk importing.
Implementation:
<GlobalExtract>modal that triggers on the URL hash pattern#extract?filename=...&importer=....loading_state.await(), keeping the PR focused and inheriting generic UI loading enhancements natively.Let me know of any questions or feedback!
Thanks