Fix document metadata links on transaction postings#2282
Open
cvaske wants to merge 3 commits into
Open
Conversation
When a document metadata key is attached to a posting rather than the transaction itself, the journal view was generating a broken link missing the entry_hash parameter. This was caused by _render_metadata being called without entry_hash for posting-level metadata in _journal_table.html. A second related bug in statement_path meant that even with a valid entry_hash, the backend only searched entry.meta and not posting-level metadata, so the document could never be resolved. Both are fixed, with a test covering the posting-level case. Additionally, updating python test snapshots to ensure testing success.
cvaske
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a document metadata key is attached to a posting rather than the transaction itself, the journal view was generating a broken link missing the entry_hash parameter. This was caused by _render_metadata being called without entry_hash for posting-level metadata in _journal_table.html. A second related bug in statement_path meant that even with a valid entry_hash, the backend only searched entry.meta and not posting-level metadata, so the document could never be resolved. Both are fixed, with a test covering the posting-level case.
Additionally, updating python test snapshots to ensure
make testpasses.Fixes #1866