Skip to content

beancount: Fix type annotation for postings.other_accounts column #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dnicolodi merged 3 commits into from
Jun 11, 2026
Merged

beancount: Fix type annotation for postings.other_accounts column #289

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d75791b
beancount: Fix type annotation for postings.other_accounts column
dnicolodi Jun 11, 2026
dfa4a7b
ci: Add Python 3.14 to tests matrix
dnicolodi Jun 11, 2026
5fecfcd
ci: Test with latest beancount
dnicolodi Jun 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,10 @@ jobs:
- '3.11'
- '3.12'
- '3.13'
- '3.14'
beancount:
- '~= 2.3.6'
- '~= 3.0.0'
- '~= 3.0'
- '@ git+https://github.com/beancount/beancount.git'
exclude:
- python: '3.8'
Expand Down
4 changes: 2 additions & 2 deletions beanquery/sources/beancount.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -513,10 +513,10 @@ def account(context):
"""The account of the posting."""
return context.posting.account

@columns.register(set)
@columns.register(typing.Set[str])
def other_accounts(context):
"""The list of other accounts in the transaction, excluding that of this posting."""
return sorted({posting.account for posting in context.entry.postings if posting is not context.posting})
return {posting.account for posting in context.entry.postings if posting is not context.posting}

@columns.register(Decimal)
def number(context):
Expand Down
Loading