Skip to content

Avoid a quadratic excludes check in pkg_files #1088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fmeum wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Avoid a quadratic excludes check in pkg_files #1088

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion pkg/mappings.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,9 +228,12 @@ def _pkg_files_impl(ctx):
# Exclude excludes
srcs = [] # srcs is source File objects, not Targets
file_to_target = {}

# A dict avoids scanning all excludes for every file.
excludes = {f: None for f in ctx.files.excludes}
for src in ctx.attr.srcs:
for f in src[DefaultInfo].files.to_list():
if f not in ctx.files.excludes:
if f not in excludes:
srcs.append(f)
file_to_target[f] = src

Expand Down
Loading