Skip to content

feat: add iceoryx#1274

Merged
fmeum merged 2 commits intobazelbuild:mainfrom
wep21:add-iceoryx
Dec 24, 2024
Merged

feat: add iceoryx#1274
fmeum merged 2 commits intobazelbuild:mainfrom
wep21:add-iceoryx

Conversation

@wep21
Copy link
Copy Markdown
Contributor

@wep21 wep21 commented Jan 6, 2024

fmeum
fmeum requested changes Jan 6, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@fmeum fmeum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lockfile isn't needed here (or in the archive).

@wep21 wep21 force-pushed the add-iceoryx branch 2 times, most recently from 3c96b34 to bbb15e9 Compare January 6, 2024 08:54
@wep21 wep21 requested a review from fmeum January 6, 2024 09:05
@wep21
Copy link
Copy Markdown
Contributor Author

wep21 commented Jan 6, 2024

@fmeum I'm sorry, I removed the lockfile.

@fmeum fmeum added presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval skip-url-stability-check Skip the URL stability check for the PR labels Jan 6, 2024
fmeum
fmeum previously approved these changes Jan 6, 2024
View reviewed changes
Comment thread modules/iceoryx/2.0.5/source.json Outdated
@fmeum
Copy link
Copy Markdown
Contributor

fmeum commented Jan 6, 2024

Looks like CI is failing due to missing build files, but the BCR setup looks good.

@wep21 wep21 force-pushed the add-iceoryx branch 2 times, most recently from 3266489 to cd18c45 Compare January 6, 2024 09:34
@wep21 wep21 marked this pull request as draft January 6, 2024 10:05
@wep21 wep21 force-pushed the add-iceoryx branch 3 times, most recently from 2de3308 to a6ff15a Compare January 7, 2024 15:46
@wep21
Copy link
Copy Markdown
Contributor Author

wep21 commented Jan 7, 2024

@fmeum Do you know how to handle patch adding empty file? It causes a patch error as below.
https://buildkite.com/bazel/bcr-presubmit/builds/2987#018ce4a0-352b-47bb-8c25-a5759631964c/236-266

@fmeum
Copy link
Copy Markdown
Contributor

fmeum commented Jan 9, 2024

@wep21 How did you generate the patch? The Bazel implementation of patch can be a bit strict at times. I would recommend using git diff to generate the patch, those usually work.

@bazel-io bazel-io dismissed fmeum’s stale review December 23, 2024 08:17

Require module maintainers' approval for newly pushed changes.

@bazel-io
Copy link
Copy Markdown
Member

bazel-io commented Dec 23, 2024

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (iceoryx) have been updated in this PR. Please review the changes.

@wep21 wep21 force-pushed the add-iceoryx branch 4 times, most recently from b4884ee to 1acbf7d Compare December 23, 2024 08:33
@wep21
feat: add iceoryx
a6f9b4d 
Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>
@wep21 wep21 closed this Dec 23, 2024
@wep21 wep21 reopened this Dec 23, 2024
@wep21 wep21 force-pushed the add-iceoryx branch 8 times, most recently from df67647 to 411bf92 Compare December 23, 2024 12:23
@wep21
update
a9e2271 
Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>
@wep21 wep21 marked this pull request as ready for review December 23, 2024 12:36
@wep21
Copy link
Copy Markdown
Contributor Author

wep21 commented Dec 23, 2024

@fmeum @meteorcloudy ready to review

@wep21 wep21 requested a review from fmeum December 23, 2024 12:37
fmeum
fmeum reviewed Dec 23, 2024
View reviewed changes
Comment thread modules/iceoryx/2.95.3/MODULE.bazel
@wep21 wep21 requested a review from fmeum December 23, 2024 14:16
@fmeum fmeum merged commit 977814c into bazelbuild:main Dec 24, 2024
@wep21 wep21 deleted the add-iceoryx branch December 24, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fmeum fmeum fmeum approved these changes

+1 more reviewer

@lalten lalten lalten left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval skip-url-stability-check Skip the URL stability check for the PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wep21 @fmeum @bazel-io @lalten