fixed paths to home directory#613
Open
HenFo wants to merge 1 commit into
Open
Conversation
$USER does not automatically matches the $HOME directory
There was a problem hiding this comment.
Pull request overview
This PR updates desktop-entry generation scripts to use the actual home directory ($HOME) instead of constructing paths from $USER, avoiding incorrect paths when the username doesn’t map 1:1 to the home directory name (e.g., usernames containing @).
Changes:
- Replaced hard-coded
/home/$USER/...icon paths with$HOME/...in multiple.desktopgenerators. - Updated
Exec=entries that referenced/home/$USER/...alacritty config paths to use$HOME/....
Tip
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| install/desktop/optional/app-cursor.sh | Updates Cursor desktop entry icon path to use the actual home directory. |
| applications/WhatsApp.sh | Uses $HOME for the WhatsApp icon path when generating the desktop entry. |
| applications/Omakub.sh | Uses $HOME for alacritty config path and icon path in the desktop entry. |
| applications/Neovim.sh | Uses $HOME for the alacritty config path in the desktop entry. |
| applications/HEY.sh | Uses $HOME for the HEY icon path when generating the desktop entry. |
| applications/Docker.sh | Uses $HOME for alacritty config path and icon path in the desktop entry. |
| applications/Basecamp.sh | Uses $HOME for the Basecamp icon path when generating the desktop entry. |
| applications/Activity.sh | Uses $HOME for alacritty config path and icon path in the desktop entry. |
| applications/About.sh | Uses $HOME for alacritty config path and icon path in the desktop entry. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| Comment=AI-powered code editor | ||
| Exec=/opt/cursor.appimage --no-sandbox | ||
| Icon=/home/$USER/.local/share/omakub/applications/icons/cursor.png | ||
| Icon=$HOME/.local/share/omakub/applications/icons/cursor.png |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The used $USER does not automatically match the $HOME directory.
The username can contain invalid path characters like '@', which are stripped away from the home directory name.