Fix space-bar schema copy to handle split schema files#612
Open
j4viermora wants to merge 3 commits into
Open
Conversation
space-bar split its single gschema.xml into four separate files (appearance, behavior, shortcuts, state) in a recent version. The previous cp targeting org.gnome.shell.extensions.space-bar.gschema.xml silently failed, causing all subsequent gsettings calls for space-bar to fail — including clearing the open-menu shortcut. This left <Super>W bound to the workspace rename menu instead of GNOME WM's close-window binding. Using a wildcard works for both old and new versions of the extension.
There was a problem hiding this comment.
Pull request overview
Updates desktop setup scripts to keep GNOME extension configuration working with Space Bar’s split GSettings schemas, and refreshes Spotify apt repository key handling.
Changes:
- Copy all Space Bar
*.gschema.xmlfiles when compiling schemas sogsettingsconfiguration works across both old and new Space Bar schema layouts. - Update Spotify installer script to use the new Spotify apt signing key.
- Add a migration to update the Spotify apt signing key on existing systems.
Tip
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| migrations/1770656330.sh | Adds a migration to refresh Spotify apt key/repo configuration on existing installs. |
| install/desktop/set-gnome-extensions.sh | Adjusts Space Bar schema copying to support split schema files before compiling schemas. |
| install/desktop/optional/app-spotify.sh | Updates Spotify apt key used during installation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| sudo cp ~/.local/share/gnome-shell/extensions/just-perfection-desktop\@just-perfection/schemas/org.gnome.shell.extensions.just-perfection.gschema.xml /usr/share/glib-2.0/schemas/ | ||
| sudo cp ~/.local/share/gnome-shell/extensions/blur-my-shell\@aunetx/schemas/org.gnome.shell.extensions.blur-my-shell.gschema.xml /usr/share/glib-2.0/schemas/ | ||
| sudo cp ~/.local/share/gnome-shell/extensions/space-bar\@luchrioh/schemas/org.gnome.shell.extensions.space-bar.gschema.xml /usr/share/glib-2.0/schemas/ | ||
| sudo cp ~/.local/share/gnome-shell/extensions/space-bar\@luchrioh/schemas/*.gschema.xml /usr/share/glib-2.0/schemas/ |
Comment on lines
+3
to
+7
| # Update Spotify GPG key if the repository is present | ||
| if [ -f /etc/apt/sources.list.d/spotify.list ]; then | ||
| echo "Updating Spotify GPG key..." | ||
| curl -sS https://download.spotify.com/debian/pubkey_5384CE82BA52C83A.gpg | sudo gpg --dearmor --yes -o /etc/apt/trusted.gpg.d/spotify.gpg | ||
| echo "deb [signed-by=/etc/apt/trusted.gpg.d/spotify.gpg] https://repository.spotify.com stable non-free" | sudo tee /etc/apt/sources.list.d/spotify.list |
Comment on lines
5
to
7
| [ -f /etc/apt/trusted.gpg.d/spotify.gpg ] && sudo rm /etc/apt/trusted.gpg.d/spotify.gpg | ||
| curl -sS https://download.spotify.com/debian/pubkey_C85668DF69375001.gpg | sudo gpg --dearmor --yes -o /etc/apt/trusted.gpg.d/spotify.gpg | ||
| curl -sS https://download.spotify.com/debian/pubkey_5384CE82BA52C83A.gpg | sudo gpg --dearmor --yes -o /etc/apt/trusted.gpg.d/spotify.gpg | ||
| echo "deb [signed-by=/etc/apt/trusted.gpg.d/spotify.gpg] https://repository.spotify.com stable non-free" | sudo tee /etc/apt/sources.list.d/spotify.list |
Comment on lines
+5
to
+7
| echo "Updating Spotify GPG key..." | ||
| curl -sS https://download.spotify.com/debian/pubkey_5384CE82BA52C83A.gpg | sudo gpg --dearmor --yes -o /etc/apt/trusted.gpg.d/spotify.gpg | ||
| echo "deb [signed-by=/etc/apt/trusted.gpg.d/spotify.gpg] https://repository.spotify.com stable non-free" | sudo tee /etc/apt/sources.list.d/spotify.list |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
set-gnome-extensions.shscript copiesorg.gnome.shell.extensions.space-bar.gschema.xmlto compile its gsettings schema, but this file no longer exists. A recent version of space-bar split its schema into four separate files:org.gnome.shell.extensions.space-bar.appearance.gschema.xmlorg.gnome.shell.extensions.space-bar.behavior.gschema.xmlorg.gnome.shell.extensions.space-bar.shortcuts.gschema.xmlorg.gnome.shell.extensions.space-bar.state.gschema.xmlThe
cpsilently fails, soglib-compile-schemasnever registers space-bar's schema. As a result, all subsequentgsettings set org.gnome.shell.extensions.space-bar.*calls fail silently too — including the one that clears theopen-menushortcut.The default value of
open-menuin space-bar is['<Super>W'], which intercepts the key before GNOME WM'sclosebinding gets it. The user sees a workspace rename dialog instead of the window closing.Fix
Use a wildcard
*.gschema.xmlwhen copying space-bar's schemas. This works correctly for both the old single-file layout and the new split-file layout.Test
Verified on Ubuntu 26 — after applying this fix,
Super+Wcorrectly closes the active window.