Skip to content

Lines ending with $\ are not incomplete. #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
egwspiti wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Lines ending with $\ are not incomplete. #33

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0036681
Lines ending with $\ are not incomplete.
egwspiti Oct 9, 2015
809dada
Do not create a capture group.
egwspiti Oct 11, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/method_source/code_helpers.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,8 @@ def complete_expression?(str)
eval("BEGIN{throw :valid}\n#{str}")
end

# Assert that a line which ends with a , or \ is incomplete.
str !~ /[,\\]\s*\z/
# Assert that a line which ends with a , or \ but not with $\ is incomplete.
str !~ /(,|[^\$]\\)\s*\z/

@kyrylo kyrylo Oct 9, 2015

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would use (?:...) in order not to create a captured group.

@kyrylo kyrylo Oct 9, 2015

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect this change might break $$. Could you please check?

@egwspiti egwspiti Oct 11, 2015

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MethodSource.complete_expression?('$$') was true before this patch and is also true after this patch.

rescue IncompleteExpression
false
ensure
Expand Down
4 changes: 4 additions & 0 deletions test/test_code_helpers.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,4 +38,8 @@
}.should.raise(SyntaxError)
end
end

it "should consider as complete lines ending with $\\" do
@tester.complete_expression?('$\\').should == true
end
end