Repository navigation
feat: print a progress message before fetching packages in http client sample - #126
Conversation
…t sample The Central registry call takes a few seconds, so print a status line before it starts instead of leaving the output blank while it runs.
| string query = "aws"; | ||
| http:Client registry = check new ("https://api.central.ballerina.io/2.0/registry"); | ||
|
|
||
| io:println(string `Fetching popular packages for query '${query}' from Ballerina Central...`); |
There was a problem hiding this comment.
Should we use ballerina/log. I am not sure it is good to have mix of io and log.
There was a problem hiding this comment.
From connector team, we follow and recommend the convention to use io prints in main function examples and log statements for service examples.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe HTTP client example now prints a package-fetch status message before querying Ballerina Central. The E2E fixture includes the new output line. ChangesHTTP client status output
Estimated code review effort: 1 (Trivial) | ~3 minutes Merge Risk: ⚪ Minimal · up to This change only adds a progress message and updates the corresponding example output; no actionable merge-blocking risk remains after the normal fixture refresh check. Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary by CodeRabbit