Gate multiview builtin shaders on multiview feature check#3831
Merged
baldurk merged 1 commit intobaldurk:v1.xfrom Apr 20, 2026
Merged
Gate multiview builtin shaders on multiview feature check#3831baldurk merged 1 commit intobaldurk:v1.xfrom
baldurk merged 1 commit intobaldurk:v1.xfrom
Conversation
baldurk
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
CheckerboardMultiviewFSandTrisizeMultiviewFScompile with#define USE_MULTIVIEW 1, emittingOpCapability MultiView.Without a
FeatureCheck::MultiViewgate, they get compiled and passed tovkCreateShaderModuleon devices that didn't enablemultiview, producing spurious validation errors at capture init (when using RenderDoc API).Other shaders
QuadResolve/WriteMultiviewFSalready gate withFeatureCheck::MultiView.This applies the same gate to the remaining two.
It seems safe because both variants are only selected when the captured content uses multiview.