fix: use typing.Awaitable instead of collections.abc.Awaitable - #144
Open
angandotra-coursera wants to merge 1 commit into
Open
fix: use typing.Awaitable instead of collections.abc.Awaitable#144angandotra-coursera wants to merge 1 commit into
angandotra-coursera wants to merge 1 commit into
Conversation
collections.abc.Awaitable[T] isn't subscriptable until Python 3.9, but this package supports python_requires>=3.6, causing a TypeError on 3.6-3.8. Fixes awslabs#143. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
collections.abc.Awaitable[T]isn't subscriptable until Python 3.9, but this package declarespython_requires>=3.6, causingTypeError: 'ABCMeta' object is not subscriptableon Python 3.6-3.8.typing.Awaitable, which supports subscripting on all supported versions.Fixes #143
Test plan
toxrun locally: flake8 OK, mypy OK, unit tests pass (168 passed; 2 pre-existing failures unrelated to this change, inconvert_to_millisecondsdatetime.max edge case)