fix(aws-load-balancer-controller): add correctly spelled ingressValidationFailurePolicy - #1357
Open
buddy-n8n wants to merge 1 commit into
Open
Conversation
…ationFailurePolicy webhookConfig.ingressValdationFailurePolicy (missing the "i" in "Validation") is the only key the ingress validating webhook's failurePolicy template field reads, but the misspelling makes the intent easy to miss and easy to set wrong by copying the "correct" English spelling. Add webhookConfig.ingressValidationFailurePolicy as the primary, correctly spelled key. The template now prefers it, falls back to the legacy misspelled key if only that is set, and defaults to Fail as before. The old key keeps working unchanged for existing values files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
webhookConfig.ingressValdationFailurePolicy(missing the "i" in "Validation") is the value that the Ingress validating webhook'sfailurePolicytemplate field actually reads (templates/webhook.yaml). Because the key is misspelled, users who set the intuitively "correct" spelling,webhookConfig.ingressValidationFailurePolicy, get silently ignored:Helm accepts unknown
--set/values paths without error, so the webhook stays on the chart's defaultFailpolicy instead of whatever the user intended.Concretely, this bit a consumer trying to set
failurePolicy: Ignoreso the validating webhook wouldn't block Ingress deletion when LBC pods are unhealthy during cluster teardown. Their value silently no-opped and the webhook stayed onFail.This PR:
webhookConfig.ingressValidationFailurePolicyas the primary, correctly spelled key.Fail(unchanged default behavior).webhookConfig.ingressValdationFailurePolicyworking as a deprecated alias, so existing values files are unaffected.README.mdand bumps the chart version (3.5.0 -> 3.5.1).No behavior changes for existing users who don't touch this setting, or who already use the misspelled key. Users who previously tried the correctly spelled key and got silently ignored will now get the behavior they asked for.
Checklist
helm lintpasses for the modified charttemplates/webhook.yamlwithhelm templatefor: default, old key only, new key only, and both keys set (new key wins): all four match expectationsType of change