Skip to content

[aws-load-balancer-controller] Add support for multiple namespaces in watchNamespace #1318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ahmedsamer wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[aws-load-balancer-controller] Add support for multiple namespaces in watchNamespace #1318

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion stable/aws-load-balancer-controller/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,7 @@ The default values set by the application itself can be confirmed [here](https:/
| `globalAcceleratorMaxConcurrentReconciles` | Maximum number of concurrently running reconcile loops for GlobalAccelerator objects | None |
| `globalAcceleratorMaxExponentialBackoffDelay` | Maximum duration of exponential backoff for GlobalAccelerator reconcile failures | None |
| `syncPeriod` | Period at which the controller forces the repopulation of its local object stores | None |
| `watchNamespace` | Namespace the controller watches for updates to Kubernetes objects, If empty, all namespaces are watched | None |
| `watchNamespace` | Namespace(s) the controller watches for updates to Kubernetes objects. Can be a string for a single namespace or a list for multiple namespaces. If empty, all namespaces are watched | None |
| `disableIngressClassAnnotation` | Disables the usage of kubernetes.io/ingress.class annotation | None |
| `disableIngressGroupNameAnnotation` | Disables the usage of alb.ingress.kubernetes.io/group.name annotation | None |
| `tolerateNonExistentBackendService` | whether to allow rules that reference a backend service that does not exist. (When enabled, it will return 503 error if backend service not exist) | `true` |
Expand Down
6 changes: 6 additions & 0 deletions stable/aws-load-balancer-controller/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,8 +140,14 @@ spec:
- --sync-period={{ .Values.syncPeriod }}
{{- end }}
{{- if .Values.watchNamespace }}
{{- if kindIs "slice" .Values.watchNamespace }}
{{- range .Values.watchNamespace }}
- --watch-namespace={{ . }}
{{- end }}
{{- else }}
- --watch-namespace={{ .Values.watchNamespace }}
{{- end }}
{{- end }}
{{- if kindIs "bool" .Values.disableIngressClassAnnotation }}
- --disable-ingress-class-annotation={{ .Values.disableIngressClassAnnotation }}
{{- end }}
Expand Down
10 changes: 9 additions & 1 deletion stable/aws-load-balancer-controller/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,15 @@ lbStabilizationMonitorInterval:
# Period at which the controller forces the repopulation of its local object stores. (default 10h0m0s)
syncPeriod:

# Namespace the controller watches for updates to Kubernetes objects, If empty, all namespaces are watched.
# Namespace(s) the controller watches for updates to Kubernetes objects.
# Can be a single namespace (string) or multiple namespaces (list).
# If empty, all namespaces are watched.
# Examples:
# Single namespace: watchNamespace: my-namespace
# Multiple namespaces:
# watchNamespace:
# - namespace1
# - namespace2
watchNamespace:

# disableIngressClassAnnotation disables the usage of kubernetes.io/ingress.class annotation, false by default
Expand Down