-
Notifications
You must be signed in to change notification settings - Fork 4.5k
[v2] Implement conditional prompt_toolkit importing #10231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 14 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
a30575a
Implement conditional autoprompt importing.
aemous c2a322c
Minor formatting change.
aemous 8762f7a
Fix tests based on new autoprompt interface.
aemous 389cd83
Fix remaining eager imports of prompttoolkit and autoprompt.
aemous e82544d
Add new autoprompt.exceptions file.
aemous 4a96adf
Refactor Configure SSO and SSOSession commands to achieve lazy import…
aemous 9491794
Remove year from license in sso_commands.py file.
aemous 50f107e
Add module-level comment explaining new sso_commands.py module.
aemous 05b657e
Fix bug where provided runners on wizardcommands were not being propo…
aemous bf888ff
Add changelog entry.
aemous 2e7ae88
Update enhancement-Performance-97002.json
aemous 4a3cf3b
Defer import of prompt_toolkit for 'aws configure' commands until the…
aemous de3aad1
Refactor logs customization to defer prompt_toolkit imports.
aemous adee5c9
Rename test file and update imports after logs refactor.
aemous 509f9b3
Changes based on feedback.
aemous cc38ce1
First pass of pre-commit.
aemous f82c3f8
Second pass of pre-commit.
aemous 4400280
Third pass of pre-commit
aemous f24425b
Fix new tests on Windows by porting existing BaseAWSCommandParamsTest…
aemous 7542c33
Raise timeout to 60s in new tests to address flakiness on Windows run…
aemous File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| { | ||
| "type": "enhancement", | ||
| "category": "Performance", | ||
| "description": "Defer some imports (e.g. ``prompt_toolkit``) until they are needed to reduce command initialization time (e.g. loading all imported modules)." | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| class PrompterKeyboardInterrupt(KeyboardInterrupt): | ||
| pass |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.