Skip to content

chore: request core team review through CODEOWNERS - #2109

Merged
aws-cdk-automation merged 1 commit into
mainfrom
mrgrain/chore/codeowners-core-team-review
Oct 30, 2026
Merged

aws-cdk-automation merged 1 commit into
mainfrom
mrgrain/chore/codeowners-core-team-review

Conversation

@mrgrain

@mrgrain mrgrain commented Oct 30, 2026 •

Copy link
Copy Markdown
Collaborator

The Triage-Pull-Requests job in issue-label-assign requests aws-cdk-core-team as reviewer on every new PR. To do so, it needs to use a token with permissions it now no longer has. This has caused the job to fail with Could not resolve to a node with the global id of 'T_kwDOACIPmc4AsOH1' error.

Instead we add .github/CODEOWNERS using the same team, which makes GitHub request its review on every non-draft PR without the need for tokens at all. The Triage-Pull-Requests job now becomes redundant and is removed. We can also remove its pull_request_target trigger, which is always a good thing given the elevated permissions of that workflow.

All together, this is a much better solution to achieve the same goal. Of course I am not really sure what the point of the request reviewers was in the first, but here we are.

Checklist

  • This change contains a major version upgrade for a dependency and I confirm all breaking changes are addressed
    • Release notes for the new version:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions

Copy link
Copy Markdown
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@mrgrain
mrgrain deployed to no-approval October 30, 2026 11:21 — with GitHub Actions Active
@github-actions github-actions Bot added the p2 label Oct 30, 2026
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.05%. Comparing base (fee6951) to head (b364809).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2109      +/-   ##
==========================================
- Coverage   92.08%   92.05%   -0.04%     
==========================================
  Files          83       83              
  Lines       13246    13246              
  Branches     1886     1884       -2     
==========================================
- Hits        12197    12193       -4     
- Misses       1011     1015       +4     
  Partials       38       38              
Flag Coverage Δ
suite.unit 92.05% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mrgrain mrgrain added the pr/exempt-integ-test Skips the integ test steps if set. label Oct 30, 2026

This branch had an error being deployed

1 failed (outdated), 1 active, and 1 inactive deployments
run-tests — b3648092 Deployed Oct 30, 2026 by mrgrain via integ_toolkit-lib (toolkit-lib-integ-tests, 20) #7523
no-approval — b3648092 Deployed Oct 30, 2026 by mrgrain via prepare #7523
automation — 295ba7ac Deployed Oct 30, 2026 by mrgrain via Triage Pull Requests #2266
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p2 pr/exempt-integ-test Skips the integ test steps if set.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants