Repository navigation
chore: request core team review through CODEOWNERS - #2109
Merged
aws-cdk-automation merged 1 commit intoOct 30, 2026
Merged
Conversation
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2109 +/- ##
==========================================
- Coverage 92.08% 92.05% -0.04%
==========================================
Files 83 83
Lines 13246 13246
Branches 1886 1884 -2
==========================================
- Hits 12197 12193 -4
- Misses 1011 1015 +4
Partials 38 38
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
rix0rrr
approved these changes
Oct 30, 2026
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Triage-Pull-Requestsjob inissue-label-assignrequestsaws-cdk-core-teamas reviewer on every new PR. To do so, it needs to use a token with permissions it now no longer has. This has caused the job to fail withCould not resolve to a node with the global id of 'T_kwDOACIPmc4AsOH1'error.Instead we add
.github/CODEOWNERSusing the same team, which makes GitHub request its review on every non-draft PR without the need for tokens at all. TheTriage-Pull-Requestsjob now becomes redundant and is removed. We can also remove itspull_request_targettrigger, which is always a good thing given the elevated permissions of that workflow.All together, this is a much better solution to achieve the same goal. Of course I am not really sure what the point of the request reviewers was in the first, but here we are.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license