Skip to content

chore: publish cli-integ to npm only after aws-cdk is published - #2095

Merged
aws-cdk-automation merged 2 commits into
mainfrom
chore/cli-integ-publish-after-cli
Oct 28, 2026
Merged

chore: publish cli-integ to npm only after aws-cdk is published#2095
aws-cdk-automation merged 2 commits into
mainfrom
chore/cli-integ-publish-after-cli

Conversation

@iliapolo

@iliapolo iliapolo commented Oct 26, 2026

Copy link
Copy Markdown
Collaborator

@aws-cdk-testing/cli-integ doesn't depend on aws-cdk, so its npm publish job could run before the CLI is available on npm, and consumers could pick up tests that won't pass against the published CLI.

Add a NpmPublishAfter projen component that adds other packages' npm publish jobs to a package's publish job needs, and use it to order cli-integ after aws-cdk.

Checklist

  • This change contains a major version upgrade for a dependency and I confirm all breaking changes are addressed
    • Release notes for the new version:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@iliapolo
chore: publish cli-integ to npm only after aws-cdk is published
161f88f 
`@aws-cdk-testing/cli-integ` doesn't depend on `aws-cdk`, so its npm publish
job could run before the CLI is available on npm, and consumers could pick up
tests that won't pass against the published CLI.

Add a `NpmPublishAfter` projen component that adds other packages' npm publish
jobs to a package's publish job `needs`, and use it to order cli-integ after
aws-cdk.
@iliapolo
iliapolo deployed to automation October 26, 2026 19:14 — with GitHub Actions Active
@github-actions github-actions Bot added the p2 label Oct 26, 2026
@github-actions

github-actions Bot commented Oct 26, 2026

Copy link
Copy Markdown
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@iliapolo
iliapolo deployed to no-approval October 26, 2026 19:16 — with GitHub Actions Active
@aws-cdk-automation
aws-cdk-automation added this pull request to the merge queue Oct 28, 2026
Merged via the queue into main with commit 95683e3 Oct 28, 2026
80 of 83 checks passed

This branch was successfully deployed

2 active (1 outdated) and 1 inactive deployments
run-tests — 7801af1d Deployed Oct 28, 2026 by aws-cdk-automation via integ_init-templates (init-fsharp, 24.19) #7481
no-approval — 7801af1d Deployed Oct 26, 2026 by aws-cdk-automation via prepare #7481
automation — 161f88f9 Deployed Oct 26, 2026 by iliapolo via Set AutoQueue on PR #2095 #3871
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rix0rrr rix0rrr rix0rrr approved these changes
+1 more reviewer
@maintainer-for-aws maintainer-for-aws[bot] maintainer-for-aws[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

p2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@iliapolo @codecov-commenter @rix0rrr @aws-cdk-automation