feat: include AWS credits in cost accounting#98
Open
sway4em wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR provides an implementation for issue #97.
Summary
Removes the RECORD_TYPE filter that excludes Credit/Refund records from Cost Explorer queries, allowing organizations using AWS Credits to see actual resource consumption in cost reports.
Changes
getGetCostAndUsageCommandInput()methodProblem
Organizations that primarily use AWS Credits (educational institutions, startups with AWS Activate, etc.) see $0 in cost reports because Credit/Refund records are filtered out. This makes it difficult to track resource consumption, enforce budget thresholds, and report on credit utilization.
Testing
Note to Maintainers
We understand that this change affects all deployments. If a configuration toggle is preferred (to let admins choose whether to include credits), we're happy to implement that instead. This PR is offered as a starting point for discussion.
Thank you for maintaining this project.
Closes #97
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms
of your choice.