feat: Add --ip flag to show VM IP addresses in list (issue#22)#32
Open
Douglas019BR wants to merge 8 commits into
Open
feat: Add --ip flag to show VM IP addresses in list (issue#22)#32Douglas019BR wants to merge 8 commits into
Douglas019BR wants to merge 8 commits into
Conversation
Add /smart-sizing flag to xfreerdp command on Linux/Mac so the VM window can be resized without black areas. The VM image scales to fill the window client-side. Document the limitation in README: for true dynamic resolution (VM re-renders at the new size), Hyper-V Enhanced Session must be enabled on the host. Include PowerShell instructions and a note about xrdp requirement for Linux guests
Add optional --ip/-i flag to list and ls commands to display VM IP addresses in a new column. Implementation details: - Add batch IP retrieval using Get-VMNetworkAdapter (single call) - Filter IPv6 and link-local IPs (169.254.x.x), prefer IPv4 - Add _get_all_vm_ip_addresses() for batch PowerShell call - Add _select_primary_ip() for intelligent IP selection - Add add_ip_addresses() to correlate IPs with VMs - Update printer to conditionally show IP column - Maintain backward compatibility (flag is optional) VMs without IPs (powered off, saved, or no Integration Services) display 'N/A' in the IP column. Closes avanzzzi#22
…nto merge/all-open-prs
config.load() already decodes the base64 password and stores the plain bytes in config['pass']. The subsequent b64decode() calls in connect(), run_cmd_ssh() and run_cmd_winrm() were decoding an already decoded value, causing binascii.Error: Incorrect padding.
config['pass'] is bytes after b64decode in config.load(), formatting it directly into the freerdp command produced literal b'...' strings. Also adds domain to the username for NLA authentication.
Merge/all open prs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add optional --ip/-i flag to list and ls commands to display
VM IP addresses in a new column.
Implementation details:
VMs without IPs (powered off, saved, or no Integration Services)
display 'N/A' in the IP column.
Closes #22