-
Notifications
You must be signed in to change notification settings - Fork 851
feat(vms/evm/sync): add protobuf wire types and a network client #5352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from 3 commits
ce76330
1ee8285
b6c48ba
80a4650
ee9df73
f5e73ab
5b6156a
976f703
432dee4
b9461ef
aed59ba
f96c006
eaba9bd
0360e4d
0c17b16
b3a26bd
3b63365
47889ce
1c28dbe
abf9a4d
327e6cc
6720b79
36b6bee
b86140c
835935c
d4bafb1
1ff7ca5
2bfe7ff
6fc7af1
04f2b81
7c62655
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -28,6 +28,9 @@ const ( | |
| SignatureRequestHandlerID | ||
| FirewoodRangeProofHandlerID | ||
| FirewoodChangeProofHandlerID | ||
| EVMLeafsRequestHandlerID | ||
| EVMCodeRequestHandlerID | ||
| EVMBlockRequestHandlerID | ||
|
Comment on lines
+30
to
+32
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm confused as to how we are treating these protocol IDs. Aren't these all part of the "EVMStateSync" protocol? Specifically, when would we want to register an Is this because we are trying to write code that composes either Or perhaps because we are trying to write code that will work with non-EVM syncing?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. check #5352 (comment)
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I mean we definitely will NOT be registering the leaf handler with Firewood, but we do need all the others... |
||
| ) | ||
|
|
||
| var ( | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.