-
Notifications
You must be signed in to change notification settings - Fork 851
feat(vms/evm/sync): add protobuf wire types and a network client #5352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
powerslider
wants to merge
30
commits into
master
Choose a base branch
from
powerslider/5351-sync-proto-messages
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 17 commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
ce76330
feat(vms/evm/sync): add protobuf wire types and network.Client
powerslider 1ee8285
fix(vms/evm/sync): register failure on unmarshal error, not success
powerslider b6c48ba
chore: regenerate sync.pb.go after proto comment edits
powerslider 80a4650
Merge branch 'master' into powerslider/5351-sync-proto-messages
powerslider ee9df73
refactor(vms/evm/sync): make network.Client a generic Dispatcher
powerslider f5e73ab
refactor(vms/evm/sync): make network.Client a generic Dispatcher
powerslider 5b6156a
Merge branch 'master' into powerslider/5351-sync-proto-messages
powerslider 976f703
refactor(vms/evm/sync): unexport sentinels and route Send through SendTo
powerslider 432dee4
chore: cleanup
powerslider b9461ef
feat(vms/evm/sync): add caller-driven peer scoring via Outcome
powerslider aed59ba
Merge branch 'master' into powerslider/5351-sync-proto-messages
powerslider f96c006
chore: cleanup
powerslider eaba9bd
Merge branch 'master' into powerslider/5351-sync-proto-messages
powerslider 0360e4d
chore: renaming
powerslider 0c17b16
refactor(vms/evm/sync): split network clients into per-RPC packages
powerslider b3a26bd
chore: bazel metadata
powerslider 3b63365
docs: refine comments
powerslider 47889ce
Merge branch 'master' into powerslider/5351-sync-proto-messages
powerslider 1c28dbe
Merge branch 'master' into powerslider/5351-sync-proto-messages
powerslider abf9a4d
refactor(vms/evm/sync): apply some review feedback
powerslider 327e6cc
chore: bazel metadata
powerslider 6720b79
refactor(vms/evm/sync/network): drop NodeID from Send return
powerslider 36b6bee
refactor(proto/sync): split atomic-trie handler, rename parents
powerslider b86140c
docs(proto/sync): patch comment
powerslider 835935c
refactor(vms/evm/sync/network): tighten Outcome contract and bookkeeping
powerslider d4bafb1
test(vms/evm/sync): drop alias-only per-context tests
powerslider 1ff7ca5
refactor(vms/evm/sync): unexport error sentinels, drop dead synctest …
powerslider 2bfe7ff
Merge branch 'master' into powerslider/5351-sync-proto-messages
powerslider 6fc7af1
refactor(vms/evm/sync/network): apply review nits and guard pre-cance…
powerslider 04f2b81
Merge branch 'master' into powerslider/5351-sync-proto-messages
powerslider File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm confused as to how we are treating these protocol IDs.
Aren't these all part of the "EVMStateSync" protocol? Specifically, when would we want to register an
EVMLeafsRequestHandlerID, but not anEVMCodeRequestHandlerID, or anEVMBlockRequestHandlerID?Is this because we are trying to write code that composes either
FirewoodProofHandlerIDorEVMLeafsRequestHandlerIDwithEVMCodeRequestHandlerIDandEVMBlockRequestHandlerID?Or perhaps because we are trying to write code that will work with non-EVM syncing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check #5352 (comment)