SEO-Friendly Naming Scheme for Image Uploads with Corresponding Test Cases#1441
Open
Pushkraj19 wants to merge 7 commits intoaustintoddj:masterfrom
Open
SEO-Friendly Naming Scheme for Image Uploads with Corresponding Test Cases#1441Pushkraj19 wants to merge 7 commits intoaustintoddj:masterfrom
Pushkraj19 wants to merge 7 commits intoaustintoddj:masterfrom
Conversation
Author
|
@austintoddj Please take a look at it and approve. Thank you. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new SEO-friendly naming scheme for image uploads in the
UploadsControllerto ensure that uploaded files have clean, descriptive, and URL-friendly filenames. The following changes have been made:SEO-Friendly Naming Scheme:
md5hash of the original name, ensuring a short and readable format.Test Cases:
testEmptyUploadIsValidated), ensuring that empty file uploads are rejected with a400response.testUploadedImageCanBeStored), which verifies that images are uploaded correctly with the newly generated SEO-friendly filename.testDeleteUploadedImage), which verifies that images can be deleted after they have been uploaded, and the file no longer exists in storage.Benefits:
This change enhances the SEO performance of image uploads while maintaining clean, understandable file naming and ensuring the upload and deletion processes work as expected.