UPSTREAM PR #2443: gix-error conversion batch 1 (part 2)

[loci-dev]

Note

Source pull request: GitoxideLabs/gitoxide#2443

Follow-up of #2423.

Tasks

• thorough review for crate gix-fs

Crates done

• TBD

  Batch 1 Migration Complete

  11 crates migrated from thiserror to gix-error, in 11 commits:
  ┌────────────────┬───────────────────────────────────────────────────────┬─────────────────────────────────────────────────────────────────────────┐
  │     Crate      │                 Error types replaced                  │                            Downstream fixes                             │
  ├────────────────┼───────────────────────────────────────────────────────┼─────────────────────────────────────────────────────────────────────────┤
  │ gix-bitmap     │ 1 (ewah::decode::Error)                               │ none                                                                    │
  ├────────────────┼───────────────────────────────────────────────────────┼─────────────────────────────────────────────────────────────────────────┤
  │ gix-quote      │ 1 (ansi_c::undo::Error)                               │ none                                                                    │
  ├────────────────┼───────────────────────────────────────────────────────┼─────────────────────────────────────────────────────────────────────────┤
  │ gix-mailmap    │ 1 (parse::Error)                                      │ none                                                                    │
  ├────────────────┼───────────────────────────────────────────────────────┼─────────────────────────────────────────────────────────────────────────┤
  │ gix-fs         │ 1 (to_normal_path_components::Error)                  │ none                                                                    │
  ├────────────────┼───────────────────────────────────────────────────────┼─────────────────────────────────────────────────────────────────────────┤
  │ gix-lock       │ 1 (acquire::Error)                                    │ gix-testtools                                                           │
  ├────────────────┼───────────────────────────────────────────────────────┼─────────────────────────────────────────────────────────────────────────┤
  │ gix-path       │ 2 (relative_path::Error, realpath::Error)             │ gix-ref                                                                 │
  ├────────────────┼───────────────────────────────────────────────────────┼─────────────────────────────────────────────────────────────────────────┤
  │ gix-packetline │ 3 (encode::Error, decode::Error, decode::band::Error) │ none                                                                    │
  ├────────────────┼───────────────────────────────────────────────────────┼─────────────────────────────────────────────────────────────────────────┤
  │ gix-attributes │ 2 (name::Error, parse::Error)                         │ gix-pathspec                                                            │
  ├────────────────┼───────────────────────────────────────────────────────┼─────────────────────────────────────────────────────────────────────────┤
  │ gix-url        │ 3 (parse::Error, UrlParseError, expand_path::Error)   │ gix-transport, gix                                                      │
  ├────────────────┼───────────────────────────────────────────────────────┼─────────────────────────────────────────────────────────────────────────┤
  │ gix-hash       │ 7 (all error types)                                   │ gix-object, gix-pack, gix-odb, gix-index, gix-status, gix-protocol, gix │
  ├────────────────┼───────────────────────────────────────────────────────┼─────────────────────────────────────────────────────────────────────────┤
  │ gix-features   │ 3 (DecompressError, CompressError, inflate::Error)    │ (included in gix-hash downstream)                                       │
  └────────────────┴───────────────────────────────────────────────────────┴─────────────────────────────────────────────────────────────────────────┘
  Verification: cargo check -p gix passes, all 21 test suites across the 11 crates pass with 0 failures.

[loci-review]

Overview

This analysis evaluates commit e9e97d3, which migrates gix-fs from thiserror to gix-error. Across 30,870 functions, 1,864 were modified (6.0%), 4,607 added, and 4,626 removed.

Binaries analyzed:

• target.aarch64-unknown-linux-gnu.release.gix: +0.014% power consumption (803,371.47 nJ → 803,482.38 nJ)
• target.aarch64-unknown-linux-gnu.release.ein: -0.025% power consumption (296,296.35 nJ → 296,222.37 nJ)

Power consumption remains essentially neutral, indicating minimal impact on overall execution efficiency.

Function Analysis

Error Formatting Functions show 300-1,200% response time increases due to recursive error tree traversal in gix-error's Debug/Display implementations. Examples include gix_glob::pattern::Mode::fmt (+1,232%, 1.2μs → 15.9μs) and gix_merge::blob::Error::fmt (+538%, 2.5μs → 16.0μs). These affect only error/logging paths, not hot paths.

Error Destructor Functions show 400-600% throughput increases due to complex cleanup of Box<Frame> structures with recursive error trees. Validation error drops increased +585% (19ns → 133ns) and remote error drops +498% (29ns → 175ns). Absolute overhead remains sub-microsecond.

Performance-Critical Anomalies require investigation:

• gix_features::parallel::in_parallel: +557% response time (117μs → 766μs), +1,114% throughput (330ns → 4,002ns) with zero source changes
• gix_pack::objects: +515% response time (126μs → 776μs) with unchanged self-time, indicating downstream regression
• gix_status::ReduceChange::feed: +609% response time (1.7μs → 12.3μs) with stable self-time

Pack Cache Operations show +2,238% throughput (15ns → 356ns) but only +4% response time (504ns → 525ns), suggesting compiler inlining changes rather than genuine regression.

Positive Optimization: crossbeam_channel::IntoIter::next improved -3.74% response time (65.6μs → 63.2μs) despite +742% throughput, indicating beneficial inlining.

Additional Findings

The severe regressions in parallel processing primitives (in_parallel, in_parallel_with_finalize) and pack operations (objects) lack source code justification. These functions are architecturally isolated from gix-fs changes, suggesting compiler optimization differences or build configuration variations between versions. Runtime profiling is recommended to validate whether static analysis predictions reflect real-world performance, as these functions are critical for pack operations and status computation identified in project insights.

🔎 Full breakdown: Loci Inspector.
💬 Questions? Tag @loci-dev.