Skip to content

UPSTREAM PR #2377: feat: add sha256 feature to gix-commitgraph#15

Open
loci-dev wants to merge 4 commits intomainfrom
loci/pr-2377-add-sha-256-to-gix-commitgraph
Open

UPSTREAM PR #2377: feat: add sha256 feature to gix-commitgraph#15
loci-dev wants to merge 4 commits intomainfrom
loci/pr-2377-add-sha-256-to-gix-commitgraph

Conversation

@loci-dev
Copy link
Copy Markdown

@loci-dev loci-dev commented Feb 2, 2026

Note

Source pull request: GitoxideLabs/gitoxide#2377

This PR adds the sha256 feature to gix-commitgraph. I opened it as a draft, so we have a space where we can discuss how to best approach testing this new feature.

This PR was triggered by a comment in #2359.

@loci-dev loci-dev force-pushed the main branch 26 times, most recently from 0189b08 to 4387ffb Compare February 7, 2026 07:11
@loci-review
Copy link
Copy Markdown

loci-review bot commented Feb 7, 2026

Overview

Analysis of 27,122 functions across two Gitoxide binaries reveals negligible performance impact between versions. Modified functions: 533 (1.96%), new: 1,009, removed: 1,009, unchanged: 24,571 (90.59%).

Power Consumption:

  • target.aarch64-unknown-linux-gnu.release.ein: -0.007% (294,027.58 nJ vs 294,007.38 nJ)
  • target.aarch64-unknown-linux-gnu.release.gix: -0.002% (786,468.54 nJ vs 786,452.90 nJ)

Function Analysis

Two functions analyzed show minimal throughput time increases without performance concerns:

rayon_core::StackJob::into_result (ein binary): Throughput time increased 3.85ns (+5.24%), response time stable at 203.9µs (-0.0006%). External dependency function from rayon_core with no source changes. Not in Gitoxide's performance-critical paths.

gix::revision::spec::parse::delegate::Revision::find_ref (ein binary): Throughput time increased 3.49ns (+2.34%), response time stable at 6.92µs (-0.01%). No source code changes detected; variations attributable to compiler optimizations. Used in non-critical revision parsing operations.

Both changes represent normal compiler variance without functional modifications. Performance-critical subsystems (object access, pack operations, parallel processing) remain unaffected.

🔎 Full breakdown: Loci Inspector.
💬 Questions? Tag @loci-dev.

@loci-dev loci-dev force-pushed the main branch 2 times, most recently from adf2b54 to 002971b Compare February 9, 2026 07:21
@loci-dev loci-dev force-pushed the main branch 4 times, most recently from 8124417 to dccca45 Compare February 19, 2026 07:49
@loci-dev loci-dev force-pushed the main branch 5 times, most recently from f045646 to e746ced Compare February 27, 2026 07:49
@loci-dev loci-dev force-pushed the main branch 3 times, most recently from 3a9c4ae to a28c634 Compare March 10, 2026 07:47
@loci-dev loci-dev force-pushed the main branch 4 times, most recently from 3deba97 to 9b41e5f Compare March 18, 2026 07:49
@loci-dev loci-dev force-pushed the main branch 6 times, most recently from 95ef755 to a9e7940 Compare March 26, 2026 07:51
@loci-dev loci-dev force-pushed the main branch 5 times, most recently from 8b02847 to 1bf0519 Compare April 2, 2026 07:54
@loci-dev loci-dev force-pushed the main branch 3 times, most recently from cdbe120 to 78a7ab5 Compare April 11, 2026 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants