Skip to content

Sentinel's own findings fixed, plus Ruby and Go coverage - #1754

Merged
keshav55 merged 8 commits into
masterfrom
codex/claude-sentinel-self-fixes-and-rsi-20261106-220348
Nov 6, 2026
Merged

keshav55 merged 8 commits into
masterfrom
codex/claude-sentinel-self-fixes-and-rsi-20261106-220348

Conversation

@keshav55

@keshav55 keshav55 commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

Sentinel's first full runs, then what they taught it.

Fixed in this CLI (confirmed by sentinel, checked by a second model):

  • The token prompt printed the pasted login token, and still did when stdout went to a file. Secret prompts now hide it. Checked in a real terminal both ways; the old code leaked in both.
  • site deploy --api-base http://... sent the login token unencrypted to any host. Plain http is now loopback only.

Sentinel improvements from real runs:

  • Maps Ruby, Go, and Java code, crypto primitives, and gem manifests. A Ruby crypto library went from 0 to 12 areas, a Ruby GraphQL auth library from 4 to 35. A Python repo stays at 30.
  • Hunters and checkers read installed library versions (lockfiles, venvs, node_modules) before calling a version unknown. The phone app run had sent that question to the owner.
  • The plan says how many hunters it will actually send and how many runs a full pass takes.

Tests: sentinel 20, secret prompt and deploy 3, site deploy 17, all passing.

keshav55 and others added 8 commits November 6, 2026 14:05
…s machine

Sentinel's first full run on this repo confirmed both: the token prompt printed
the pasted credential, and site deploy sent the login token over any http base.

Co-authored-by: Atris <299057014+atris-builder[bot]@users.noreply.github.com>
…runs a full pass takes

Co-authored-by: Atris <299057014+atris-builder[bot]@users.noreply.github.com>
Codex review: with stdout sent to a file, readline fell back to plain mode and
the terminal echoed the typed token. Secret prompts now keep terminal mode and
write the prompt to stderr when that is the screen.

Co-authored-by: Atris <299057014+atris-builder[bot]@users.noreply.github.com>
…o the owner

The phone app audit sent a library-version question to the owner while the
installed version sat in the project's venv. Hunters and checkers now read
lockfiles, venvs, and node_modules first.

Co-authored-by: Atris <299057014+atris-builder[bot]@users.noreply.github.com>
…ifests

Planning a Ruby crypto library found 0 areas and a Ruby GraphQL authorization
library found 4: the detectors only knew JavaScript and Python shapes. Now 12
and 35. A Python repo stays at 30 areas.

Co-authored-by: Atris <299057014+atris-builder[bot]@users.noreply.github.com>
…way it batches

The ropenpgp run filed one defect twice, under two classes with two names, and
spent two checks on it. Candidates with the same function in the fingerprint and
sinks within three lines now merge before verification.

From review: the run estimate now counts batches per class and subsystem, a tiny
budget says it cannot send a hunter instead of 'about Infinity runs', the Ruby
'def authorized?' pattern matches, and bare sign()/pad() no longer pull files
into the crypto review.

Co-authored-by: Atris <299057014+atris-builder[bot]@users.noreply.github.com>
Co-authored-by: Atris <299057014+atris-builder[bot]@users.noreply.github.com>
@keshav55
keshav55 added this pull request to the merge queue Nov 6, 2026
Merged via the queue into master with commit 1c68381 Nov 6, 2026
10 checks passed
@keshav55
keshav55 deleted the codex/claude-sentinel-self-fixes-and-rsi-20261106-220348 branch November 6, 2026 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant