Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the personal chat endpoint returns HTTP 200 with
success: false, one-shotatris chat --personalprints the server's failure message but exits zero, so a script can mistake a failed request for success. Return exit 1 after printing that message. Successful replies and legacy responses without asuccessfield still exit zero.The current personal chat client does not send
message_key, so the uncertain keyed-delivery response proposed in backend PR #4839 is not currently reachable through this caller. The loopback test simulates that response to verify presentation and status. Interactive chat continues to display the message and does not retry it automatically. This change does not add idempotency or a JSON output mode;--jsonremains message text.Validation: 12 focused CLI/ask tests passed. A real CLI process against a disposable loopback HTTP server showed the old false-success exit and verifies false, successful and legacy responses and interactive no-retry behavior. An independent review passed five focused tests and verified an HTTP 503 remains a displayed nonzero failure. No live service or rollout was tested.