Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drafting a campaign with an existing ID can overwrite its judge before duplicate detection, changing the behavior of the existing campaign. This change refuses recorded IDs and existing draft directories, reserves a new directory, and writes separate exclusive judge files for retries. It also validates the ID before constructing the shell command.
Failed attempts now retain their draft files for inspection rather than recursively deleting the directory. A generated ID collision is refused and must be retried.
This remains a draft: the store check and directory reservation are not atomic. Another process can register the same ID after the check or while the judge runs, including when only drafting. Concurrent path replacement and edits before execution are also not fenced. The engine-generated judge still runs as shell code; this change does not sandbox it. Real judges, live campaigns, and rollout have not been verified.
Validation:
node --test test/campaign-new*.test.js test/campaign-store.test.js(35 passed), using temporary files and SQLite plus mocked engine responses. Independent review reproduced the missing-directory case against a temporary SQLite store.