Feat(github-actions): add multi-platform build (raspberry pi support) - #245
Feat(github-actions): add multi-platform build (raspberry pi support)#245kalioz wants to merge 4 commits into
Conversation
Allow for a more controlled workflow, and should resolve some cache issues
The community repo works fine on the amd64 infra, but not on the arm*
|
fairly certain the checks are failing because my fork doesn't have access to your repo's secret / github token (which seems wise in terms of security)... |
|
Thanks to the builds from this pr i was able to deploy this on a Raspberry Pi cluster. |
| with: | ||
| context: . | ||
| file: ./Dockerfile | ||
| platforms: linux/386,linux/amd64,linux/arm/v6,linux/arm/v7,linux/arm64,linux/ppc64le,linux/s390x |
There was a problem hiding this comment.
this can be specified as a newline separated list, which is a bit more readable.
platforms: |
linux/386
linux/amd64
linux/arm/v6
linux/arm/v7
linux/arm64
linux/ppc64le
linux/s390x| with: | ||
| context: . | ||
| file: ./Dockerfile-alpine | ||
| platforms: linux/386,linux/amd64,linux/arm/v6,linux/arm/v7,linux/arm64,linux/ppc64le,linux/s390x |
|
I can confirm the kalioz/sftp:alpine arm-edition works on my Raspberry Pi 4 (arch: arm64) :) Tested with Docker v20.10.16 and Compose v2.5.0 What will it take to incorporate this feature ? (besides resolving the current conflicts) (the atmoz/sftp:alpine (arch: amd64) image results in the dreaded error |
| with: | ||
| context: . | ||
| file: ./Dockerfile | ||
| platforms: linux/amd64 |
There was a problem hiding this comment.
This can be omitted, so it will use underlying runner architecture
|
Any news (I ask for arm64)? |
|
interested in this too! |
|
Also interested in this |
|
Hello guys, can we get this merged this please? It's been opened for four years now… Thanks! |
|
I also need this.. would it be merged if we resolved the conflicts? |
This PR adds to github-action the functionnality to build for multiple platform.
This is currently tested (and working) on amd64 (same as the actual build) and arm/v7 (raspberry pi 4).
I've had to do some workarounds to not lose any functionnality of the current github-action, (e.g. build a first time to test and a second time to actually push as buildx cannot export a multi-platform image to docker yet)
you can see the checks in my repo (kalioz/sftp:master is 1 commit behind this branch as there are some repo-specifics checks that I had to change to make it work on mine) :
I had to lightly change the
alpineimage asadduserdidn't work on the pi (missing c-dependencies, probably due to the use of the "community" repo).important note for your repo, the registry docker.pkg.github.com is in depreciation (new one is ghcr.io), but I couldn't make this one work... Might cause problems in the future :/
fixes #102