Skip to content

[ty] Benchmark salsa-rs/salsa#1174#26213

Closed
MichaReiser wants to merge 2 commits into
micha/salsa-master-benchmarkfrom
micha/salsa-1174-benchmark
Closed

[ty] Benchmark salsa-rs/salsa#1174#26213
MichaReiser wants to merge 2 commits into
micha/salsa-master-benchmarkfrom
micha/salsa-1174-benchmark

Conversation

@MichaReiser

Copy link
Copy Markdown
Member

Summary

Pin Salsa to salsa-rs/salsa#1174 to benchmark avoiding the memo-lookup type check against the Salsa master baseline in #26201.

Test Plan

Testing: All 696 ty_python_semantic tests and repository hooks passed.

@astral-sh-bot

astral-sh-bot Bot commented Jun 22, 2026

Copy link
Copy Markdown

Typing conformance results

No changes detected ✅

Current numbers
The percentage of diagnostics emitted that were expected errors held steady at 94.37%. The percentage of expected errors that received a diagnostic held steady at 89.00%. The number of fully passing files held steady at 94/134.

@astral-sh-bot

astral-sh-bot Bot commented Jun 22, 2026

Copy link
Copy Markdown

Memory usage report

Summary

Project Old New Diff Outcome
prefect 460.12MB 460.13MB +0.00% (4.69kB)
sphinx 171.11MB 171.11MB +0.00% (1.77kB)
trio 71.52MB 71.52MB -
flake8 29.71MB 29.70MB -0.04% (12.31kB) ⬇️

Significant changes

Click to expand detailed breakdown

prefect

Name Old New Diff Outcome
parsed_module 19.32MB 19.32MB +0.02% (4.69kB)

sphinx

Name Old New Diff Outcome
parsed_module 18.35MB 18.35MB +0.01% (1.77kB)

flake8

Name Old New Diff Outcome
parsed_module 9.78MB 9.77MB -0.12% (12.31kB) ⬇️

@astral-sh-bot

astral-sh-bot Bot commented Jun 22, 2026

Copy link
Copy Markdown

ecosystem-analyzer results

No diagnostic changes detected ✅

Flaky changes detected. This PR summary excludes flaky changes; see the HTML report for details.

Full report with detailed diff (timing results)

@codspeed-hq

codspeed-hq Bot commented Jun 22, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 4.65%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

❌ 1 regressed benchmark
✅ 130 untouched benchmarks
⏩ 4 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation ty_micro[large_union_narrowing] 195.5 ms 205 ms -4.65%

Tip

Investigate this regression with the CodSpeed MCP and your agent.


Comparing micha/salsa-1174-benchmark (7614d7e) with micha/salsa-master-benchmark (f185f06)

Open in CodSpeed

Footnotes

  1. 4 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@astral-sh-bot

astral-sh-bot Bot commented Jun 22, 2026

Copy link
Copy Markdown

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Formatter (stable)

✅ ecosystem check detected no format changes.

Formatter (preview)

✅ ecosystem check detected no format changes.

@MichaReiser MichaReiser force-pushed the micha/salsa-master-benchmark branch from f0c84b0 to 045f4e5 Compare June 23, 2026 13:24
@MichaReiser MichaReiser closed this Jul 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant