fix: switch to gen-lsp-types#24894
Conversation
[gen-lsp-types](https://github.com/ribru17/gen-lsp-types) is an alternative to the lsp-types crate, with types generated via codegen from the official LSP Metamodel for correctness and completeness. lsp-types issues fixed in gen-lsp-types: - gluon-lang/lsp-types#310 - gluon-lang/lsp-types#308 - gluon-lang/lsp-types#284 - gluon-lang/lsp-types#278 - gluon-lang/lsp-types#277 - gluon-lang/lsp-types#260 - gluon-lang/lsp-types#245 - gluon-lang/lsp-types#93
|
Looks like jj does not respect .gitattributes, so the CRLF tests were changed to use LF line endings... will revert those changes |
|
As a note. @ribru17 is the author of the crate. The crate is very new. |
|
Thanks for doing this work. This is a major change, and the crate still undergoes frequent changes. Given that we don't really experience any of the pains listed in the PR summary, I prefer, at least for now, to keep our very stable lsp-types crate. Switching to your crate is something we can consider once it's more established. Don't get me wrong. I'm very interested in a successor to the lsp_types crate. It's just that I think this is a bit too early days for us. |
|
I totally understand, I was pretty overzealous with this PR 😄 let me know if/when you change your mind and I'll be happy to pick this up again. (PS, you may be interested in following rust-lang/rust-analyzer#22115) |
Summary
gen-lsp-types is an alternative to the lsp-types crate, with types generated via codegen from the official LSP Metamodel for correctness and completeness.
lsp-types issues fixed in gen-lsp-types:
SnippetTextEditsupport (proposed) gluon-lang/lsp-types#310Uritype in 0.96.0 is hard to use and have almost no interoperability gluon-lang/lsp-types#284DefaultforCodeActionOptionsgluon-lang/lsp-types#260Test Plan
All affected test fixtures updated. Most (all?) are just field reordering, struct type name renaming