Skip to content

fix: switch to gen-lsp-types#24894

Closed
ribru17 wants to merge 1 commit intoastral-sh:mainfrom
ribru17:gen-lsp-types
Closed

fix: switch to gen-lsp-types#24894
ribru17 wants to merge 1 commit intoastral-sh:mainfrom
ribru17:gen-lsp-types

Conversation

@ribru17
Copy link
Copy Markdown

@ribru17 ribru17 commented Apr 28, 2026

[gen-lsp-types](https://github.com/ribru17/gen-lsp-types) is an
alternative to the lsp-types crate, with types generated via codegen
from the official LSP Metamodel for correctness and completeness.

lsp-types issues fixed in gen-lsp-types:

- gluon-lang/lsp-types#310
- gluon-lang/lsp-types#308
- gluon-lang/lsp-types#284
- gluon-lang/lsp-types#278
- gluon-lang/lsp-types#277
- gluon-lang/lsp-types#260
- gluon-lang/lsp-types#245
- gluon-lang/lsp-types#93
@ribru17
Copy link
Copy Markdown
Author

ribru17 commented Apr 28, 2026

Looks like jj does not respect .gitattributes, so the CRLF tests were changed to use LF line endings... will revert those changes

@MichaReiser
Copy link
Copy Markdown
Member

As a note. @ribru17 is the author of the crate. The crate is very new.

@MichaReiser
Copy link
Copy Markdown
Member

MichaReiser commented Apr 28, 2026

Thanks for doing this work. This is a major change, and the crate still undergoes frequent changes. Given that we don't really experience any of the pains listed in the PR summary, I prefer, at least for now, to keep our very stable lsp-types crate. Switching to your crate is something we can consider once it's more established.

Don't get me wrong. I'm very interested in a successor to the lsp_types crate. It's just that I think this is a bit too early days for us.

@ribru17
Copy link
Copy Markdown
Author

ribru17 commented Apr 28, 2026

I totally understand, I was pretty overzealous with this PR 😄 let me know if/when you change your mind and I'll be happy to pick this up again. (PS, you may be interested in following rust-lang/rust-analyzer#22115)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants