mwi/unsolicited/incoming: Fix several issues causing instability.#146
Merged
github-actions[bot] merged 1 commit intoJun 22, 2026
Merged
Conversation
There are two sipp scenarios "allowed" and "not allowed", each generating a TestEvent. The test is set to end when the TestEvent for "not allowed" arrives. The scenarios were being run in parallel however so if the "not allowed" scenario happens to finish first and generates its TestEvent, the test will fail with an "Event occurred 0 times." error because the "allowed" scenario hasn't had its chance yet. * The sipp scenarios are now run seqauentially, "allowed" first, then "not allowed". * Both scenario files were missing the closing `</scenario>` tag for some reason so that's been fixed.
Member
Author
|
cherry-pick-to: 20 |
jcolp
approved these changes
Jun 22, 2026
github-actions
Bot
added
pr-submit-testing-in-progress
pr-submit-tests-passed
and removed
pr-submit-testing-in-progress
labels
|
Workflow Check completed successfully |
github-actions
Bot
added
cherry-pick-testing-in-progress
|
Workflow CPCheck completed successfully |
github-actions
Bot
added
pre-merge-testing-in-progress
pre-merge-checks-passed
merge-in-progress
and removed
merge-approved
pre-merge-testing-in-progress
labels
|
Successfully merged to branch master and cherry-picked to ["20","21","22","23","certified/20.7","certified/22.8"] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are two sipp scenarios "allowed" and "not allowed", each generating a
TestEvent. The test is set to end when the TestEvent for "not allowed"
arrives. The scenarios were being run in parallel however so if the
"not allowed" scenario happens to finish first and generates its TestEvent,
the test will fail with an "Event occurred 0 times." error because the
"allowed" scenario hasn't had its chance yet.
"not allowed".
</scenario>tag for somereason so that's been fixed.