Skip to content

fix(uv): resolve extra-only markers during graph activation and treat them as venv-resolved in selects#1275

Merged
xangcastle merged 6 commits into
1.xfrom
xangcastle/extra-markers
Jul 8, 2026
Merged

fix(uv): resolve extra-only markers during graph activation and treat them as venv-resolved in selects#1275
xangcastle merged 6 commits into
1.xfrom
xangcastle/extra-markers

Conversation

@xangcastle

@xangcastle xangcastle commented Jul 7, 2026

Copy link
Copy Markdown
Member

This fix handles PEP 508 markers that reference the extra variable by recognizing they are not Bazel execution-environment conditions: during dependency-graph activation, real extra markers such as extra == 'build' are partially evaluated against the active extra so they collapse to unconditional or platform-only expressions, while any marker that depends solely on extra—including uv's internal conflict-routing markers—is treated as already resolved by the active dependency-group/venv and rendered as a //conditions:default arm in the generated aliases instead of an un-evaluable decide_marker select, preventing analysis failures when the venv name does not match the extra.


Changes are visible to end-users: yes/no

  • Searched for relevant documentation and updated as needed: yes/no
  • Breaking change (forces users to change their own code or config): yes/no
  • Suggested release notes appear below: yes/no

Test plan

  • Covered by existing test cases
  • New test cases added
  • Manual testing; please provide instructions so we can reproduce:

@aspect-workflows

aspect-workflows Bot commented Jul 7, 2026

Copy link
Copy Markdown

✨ Aspect Workflows Tasks

📅 Wed Jul 8 04:21:10 UTC 2026

✅ 7 successful tasks

  • ✅ buildifier · ⏱ 20.9s · 🐙 GitHub Actions · ☑️ Check
    💬 Format complete (clean)
  • ✅ gazelle · ⏱ 19.6s · 🐙 GitHub Actions · ☑️ Check
    💬 Gazelle complete (clean)
  • ✅ test (test-e2e-bazel-8) · ⏱ 35m 1s · 🐙 GitHub Actions · ☑️ Check
    💬 Bazel test complete (63/63 passed)
  • ✅ test (test-e2e-bazel-9) · ⏱ 33m 47s · 🐙 GitHub Actions · ☑️ Check
    💬 Bazel test complete (63/63 passed)
  • ✅ test (test-examples-uv_pip_compile-bazel-8) · ⏱ 26.7s · 🐙 GitHub Actions · ☑️ Check
    💬 Bazel test complete (1/1 passed · 1 cached)
  • ✅ test (test-root-bazel-8) · ⏱ 38m 58s · 🐙 GitHub Actions · ☑️ Check
    💬 Bazel test complete (126/126 passed)
  • ✅ test (test-root-bazel-9) · ⏱ 37m 58s · 🐙 GitHub Actions · ☑️ Check
    💬 Bazel test complete (125/125 passed)

⏱ Last updated Wed Jul 8 05:00:10 UTC 2026 · 📊 GitHub API quota 1,425/15,000 (10% used, resets in 52m, throttle 3×)
🚀 Powered by Aspect CLI (v2026.22.44)  |  Aspect Build · X · LinkedIn · YouTube

@xangcastle xangcastle changed the title reproduce issue with extra marker fix: issue with extra marker Jul 7, 2026
@xangcastle xangcastle changed the title fix: issue with extra marker fix(uv): resolve extra-only markers during graph activation and treat them as venv-resolved in selects Jul 8, 2026
@xangcastle
xangcastle requested a review from jbedard July 8, 2026 03:32
@xangcastle
xangcastle marked this pull request as ready for review July 8, 2026 03:32
@jbedard

jbedard commented Jul 8, 2026

Copy link
Copy Markdown
Member

Same for main?

Comment thread uv/private/extension/test_marker_simplify.bzl
@xangcastle

Copy link
Copy Markdown
Member Author

yes, same for main #1279

@xangcastle
xangcastle merged commit e798fb0 into 1.x Jul 8, 2026
17 checks passed
@xangcastle
xangcastle deleted the xangcastle/extra-markers branch July 8, 2026 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants