Fix notebook NameErrors and add scan/enrichment examples - #10
Open
ShinyaYoshida-biomet wants to merge 2 commits into
Open
Fix notebook NameErrors and add scan/enrichment examples#10ShinyaYoshida-biomet wants to merge 2 commits into
ShinyaYoshida-biomet wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Since I got these errors when I tried to execute the notebook, I fixed the name and attribute references, respectively.
Fix 1
before:
after:
Fix 2
before:
after:
Added scan and enrichment examples
The "Analysis module" section only had a
similarity/correlationexample. I added ascan_sequenceexample (CTCF motif against a sequence containing its consensus) and amotif_enrichmentexample (pulling a small set of candidate motifs bytf_family="Homeo"rather than by hardcoded ID, then showing that only the true positive comes out enriched against a matched-length background set).Both new cells were executed and their outputs saved, same as the rest of the notebook.
Test plan
jupyter execute --inplace) after each fix, confirmed no errorsNameErrors no longer occurscan/enrichmentcells produce correct, sensible output (CTCF hits found in the scan sequence; only theDbxmotif enriched in the enrichment example, as designed)