Skip to content

feat(tracking): add home artwork item impression events (NWFY and art…#17206

Merged
dblandin merged 1 commit into
nickskalkin/home-page-rail-impression-trackingfrom
nickskalkin/home-artworks-impressions
May 26, 2026
Merged

feat(tracking): add home artwork item impression events (NWFY and art…#17206
dblandin merged 1 commit into
nickskalkin/home-page-rail-impression-trackingfrom
nickskalkin/home-artworks-impressions

Conversation

@nickskalkin

@nickskalkin nickskalkin commented May 13, 2026

Copy link
Copy Markdown
Contributor

The type of this PR is: Feat

This PR solves ONYX-2118

Description

Builds on top of where we introduce home page rails impression tracking.

Adds item_viewed impression tracking for artwork cards using the same dwell/visibility behavior as railViewed.

This tracks artwork impressions in:

  • Home: New Works for You
  • Home: We Think You'll Love
  • /recommendations/artworks artwork grid

Details

  • Extracts shared dwell-based impression logic so rail and item impressions use the same observer behavior.
  • Adds a reusable ArtworkItemImpression wrapper for artwork card impressions.
  • Keeps home tracking scoped to the two rails
  • Adds /recommendations/artworks impressions tracking

@nickskalkin nickskalkin requested a review from dblandin May 13, 2026 09:26
@nickskalkin nickskalkin self-assigned this May 13, 2026
@dblandin dblandin force-pushed the nickskalkin/home-artworks-impressions branch from 393f211 to b2e6f59 Compare May 21, 2026 15:36
@dblandin dblandin force-pushed the nickskalkin/home-page-rail-impression-tracking branch from 8e3109b to 9124a25 Compare May 21, 2026 15:37
@relativeci

relativeci Bot commented May 21, 2026

Copy link
Copy Markdown

#8432 Bundle Size — 8.93MiB (+0.1%).

0c7db47(current) vs 82b9818 main#8427(baseline)

Warning

Bundle contains 29 duplicate packages – View duplicate packages

Bundle metrics  Change 4 changes Regression 2 regressions
                 Current
#8432
     Baseline
#8427
Regression  Initial JS 2.89MiB(~+0.01%) 2.89MiB
No change  Initial CSS 0B 0B
No change  Cache Invalidation 97.44% 97.44%
No change  Chunks 111 111
No change  Assets 114 114
Change  Modules 5617(+0.16%) 5608
Regression  Duplicate Modules 659(+0.46%) 656
Change  Duplicate Code 5%(+0.4%) 4.98%
No change  Packages 248 248
No change  Duplicate Packages 28 28
Bundle size by type  Change 1 change Regression 1 regression
                 Current
#8432
     Baseline
#8427
Regression  JS 8.7MiB (+0.11%) 8.69MiB
No change  Other 234.14KiB 234.14KiB

Bundle analysis reportBranch nickskalkin/home-artworks-impres...Project dashboard


Generated by RelativeCIDocumentationReport issue

@dblandin dblandin force-pushed the nickskalkin/home-artworks-impressions branch from b2e6f59 to 0c7db47 Compare May 21, 2026 15:49
@dblandin dblandin merged commit ea1a4b3 into nickskalkin/home-page-rail-impression-tracking May 26, 2026
12 checks passed
@dblandin dblandin deleted the nickskalkin/home-artworks-impressions branch May 26, 2026 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants