Conversation
…s_merge' into develop
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
| if(lastLogEntry && lastLogEntry != "") | ||
| lastLogEntry = decodeURIComponent(lastLogEntry); | ||
|
|
||
| var writeToEcl = false; // updated by checkbox onchange before popup is cleared |
rrivera747
reviewed
Jun 9, 2026
rrivera747
left a comment
rrivera747
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me - but we need to merge otsdaq PR art-daq/otsdaq#414 first
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds “end-of-run” logging enhancements to support commissioning workflows, including an opt-in UI path to write an end-of-run summary to ECL and a server-side option to suppress the standard system footer for consolidated entries.
Changes:
- Update Subsystem Launch UI copy (“FSM:” → “Run Type:”) and add an end-of-run checkbox to optionally write the run summary to ECL.
- Extend the Stop transition POST payload to include a
writeToEclflag alongside thelogEntry. - Add a
SkipFooterSOAP parameter to ECL system log entry creation, allowing callers to post consolidated text without the auto-appended footer.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| WebGUI/js/SubsystemLaunch.js | Adds end-of-run log popup checkbox and sends writeToEcl flag on Stop; minor UI label update. |
| otsdaq-utilities/ECLWriter/ECLSupervisor.cc | Adds SkipFooter SOAP parameter and conditional footer suppression for system log entries. |
Comment on lines
+2689
to
+2690
| var writeToEcl = false; // updated by checkbox onchange before popup is cleared | ||
| SubsystemLaunch._pendingWriteToEcl = false; // reset each time popup opens |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding functionality for consolidated log entries and opt-in options at the end of the run for commissioning work.