Skip to content

fix(json-schema): spread enums before passing into type.enumerated #1566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ssalbdivad merged 8 commits into from
Dec 21, 2025
Merged

fix(json-schema): spread enums before passing into type.enumerated #1566

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
61d9010
fix(json-schema): spread enums before passing into type.enumerated
chris-kreidl Dec 16, 2025
73e6477
fix(schema): handle constraints that reduce to root nodes
chris-kreidl Dec 16, 2025
bb691ca
test(json-schema): properly parse arrays with minLength: 0
chris-kreidl Dec 16, 2025
48fcc90
Merge pull request #1 from chris-kreidl/fix-minlength-zero
chris-kreidl Dec 16, 2025
0910220
Merge branch 'merged' into spread-enums
chris-kreidl Dec 16, 2025
86c7027
fix(json-schema): handle constraints that reduce to root nodes (#1567)
chris-kreidl Dec 21, 2025
e25c4d9
fix(json-schema): spread enums before passing into type.enumerated
chris-kreidl Dec 16, 2025
e7e1072
merge main
ssalbdivad Dec 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions ark/json-schema/__tests__/string.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,17 @@ contextualize(() => {
attest(tPatternString.allows("expression")).equals(true)
})

it("string enums", () => {
const enumKeys = ["keyOne", "keyTwo"]

const stringEnums = jsonSchemaToType({
type: "string",
enum: enumKeys
})

attest(stringEnums.expression).snap('"keyOne" | "keyTwo"')
})

it("minLength (0)", () => {
const schema = {
type: "string",
Expand Down
2 changes: 1 addition & 1 deletion ark/json-schema/common.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,5 @@ export const parseCommonJsonSchema = (
return type.unit(jsonSchema.const)
}

if ("enum" in jsonSchema) return type.enumerated(jsonSchema.enum)
if ("enum" in jsonSchema) return type.enumerated(...jsonSchema.enum)
}