feat: make hover tooltip delay and search radius configurable#210
Open
ApurveKaranwal wants to merge 4 commits into
Open
feat: make hover tooltip delay and search radius configurable#210ApurveKaranwal wants to merge 4 commits into
ApurveKaranwal wants to merge 4 commits into
Conversation
Contributor
Author
|
@domoritz please tell me how to fix this issue? i think so CI Builds are not able to pass. |
Member
|
You need to run the formatter. Read the error in https://github.com/apple/embedding-atlas/actions/runs/27203259746/job/80348187177#step:13:1 |
Contributor
Author
|
@domoritz sir, please check now, all the CI Builds have passed now, do let me know if i need to change anything in the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #177
Description
This PR addresses the intermittent hover tooltip behavior by exposing the internal tooltip and hit-detection constraints as configurable properties. The default values remain intact so this is fully backward compatible, but consumers can now override them for custom tooltip experiences (e.g., instant hover tooltips).
Changes Made
tooltipDelay,tooltipRecentThreshold, andhoverRadiusoptional properties to theEmbeddingViewConfiginterface.throttleTooltiputility to accept getter functions for delay and threshold timings, ensuring the reactive configuration state updates smoothly without needing to tear down the debouncer instance.hoverRadiusconfiguration down toqueryClosestPointinmosaic_client.tsto dynamically scale the nearest-neighbor hit detection.packages/viewer/test/utils.test.tsto verify the microtask and timer logic ofthrottleTooltip.Testing
npm run checkpasses successfully.packages/viewersuccessfully passes (including 3 new timing-based unit tests for the updated tooltip debouncer logic).