Integration coverage xpc helpers#1551
Open
noah-thor wants to merge 1 commit into
Open
Conversation
Code Coverage
|
noah-thor
force-pushed
the
integration-coverage-xpc-helpers
branch
2 times, most recently
from
997dc38 to
b4a4631
Compare
This fixes the LLVM coverage data not properly being emitted for XPC services. It requires piping the `LLVM_PROFILE_FILE` environment variable through to all the services and plugins. The variable itself also required the "%c" formatter to ensure that it continuously emits coverage data, otherwise when XPC services are killed via "bootout" they do not emit coverage.
noah-thor
force-pushed
the
integration-coverage-xpc-helpers
branch
from
b4a4631 to
e6f832d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Motivation and Context
This fixes the LLVM coverage data not properly being emitted for XPC
services. It requires piping the
LLVM_PROFILE_FILEenvironmentvariable through to all the services and plugins. The variable itself
also required the "%c" formatter to ensure that it continuously emits
coverage data, otherwise when XPC services are killed via "bootout" they
do not emit coverage.
Testing