fix: audit separate crash launch and error capture - #462
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The crash benchmark rejects a successful Stim run when the launch output omits the JavaScript error, even though the next
stim logs --errorscaptures it. The original collector required the token inline for Stim; the current workflow explicitly separates launching from capturing errors.Solution
Require a successful launch followed by a token-specific runtime error and source location for either arm. Accept current setup commands while still rejecting appended source inspection before diagnosis, and decode displayed shell wrappers consistently in collection and export. After recorded cleanup, retain an integrity-matched, previously verified repair proof without retaining the old audit verdict.
This changes benchmark auditing only, not Stim or benchmark prompts. Genuine timeout and isolation failures remain excluded.
Test plan
Fixes #461