chore: remove ignored Vite override - #362
Open
janicduplessis wants to merge 1 commit into
Open
Conversation
janicduplessis
marked this pull request as ready for review
September 4, 2026 20:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The root
package.jsonstill declares an npm-style Vite override, but pnpm 12 reads workspace overrides frompnpm-workspace.yaml, so the field is dead configuration. Vitest already resolves to stable Vite 8.2.2 despite the manifest claiming arolldown-vite7.3.1 substitution.Solution
Remove the dead override rather than restoring the alias. The override was added while npm was substituting the temporary
rolldown-vitepackage. The later migration from npm to pnpm left that npm-only top-level field inpackage.json, so the current pnpm 12 setup does not read it. See the introducing commit. Restoring the alias would also move the repository away from the current stable Vite 8 release, which already uses Rolldown.The lockfile is unchanged.
pnpm why viteresolves one version: Vite 8.2.2 through Vitest 5.0.0.Test plan
pnpm install --lockfile-only --offline --frozen-lockfilepnpm run format:checkpnpm run lintpnpm run buildpnpm run typecheckpnpm test(92 files, 3,515 tests)pnpm run test:e2e(20 tests)Fixes #280