fix(mariadb): add bounded Galera ordered shutdown#3108
Draft
weicao wants to merge 2 commits into
Draft
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3108 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 144 146 +2
Lines 23013 23092 +79
=====================================
- Misses 23013 23092 +79 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
podManagementPolicy: Paralleland replace the inline preStop block with/scripts/galera-prestop.shwsrep_desync=ON,wsrep_on=OFF, thenmysqladmin shutdown1.2.0-alpha.27and add focused ShellSpec coverageThis supersedes PR #3105 as the selected route. PR #3105 remains useful only as the OrderedReady trade-off evidence and should not be merged.
Validation
bash -n addons/mariadb/scripts/galera-prestop.sh addons/mariadb/scripts/galera-start.shshellspec --load-path ./shellspec --shell bash addons/mariadb/scripts-ut-spec/galera_start_spec.sh addons/mariadb/scripts-ut-spec/galera_prestop_spec.sh addons/mariadb/scripts-ut-spec/galera_parallel_shutdown_template_spec.shhelm dependency build addons/mariadbhelm template mariadb addons/mariadb >/tmp/mariadb-galera-render.yamlplus render grep confirmed:mariadb-galera-1.2.0-alpha.27podManagementPolicy: Parallelgalera-prestop.sh/scripts/galera-prestop.shFull MariaDB ShellSpec was also run:
shellspec --load-path ./shellspec --shell bash addons/mariadb/scripts-ut-specreplication_merged_replication_mode_env_wire_spec.sh, unrelated to the Galera files changed hereRuntime validation needed
Before marking ready, run IDC validation for:
grastate.datproof and auto-recoverysafe_to_bootstrap=1full force-delete recovery