fix(mysql): make semisync accountProvision statements idempotent#3098
Draft
weicao wants to merge 1 commit into
Draft
fix(mysql): make semisync accountProvision statements idempotent#3098weicao wants to merge 1 commit into
weicao wants to merge 1 commit into
Conversation
accountProvision can be retried by the controller/kbagent; CREATE USER without IF NOT EXISTS fails with ERROR 1396 on re-execution and the provision never converges. Align kbdataprotection/kbprobe/kbmonitoring/ proxysql with the orc variant's CREATE USER IF NOT EXISTS. Fixes #3097 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3098 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 144 144
Lines 23013 23013
=====================================
Misses 23013 23013 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3097.
Four-statement change in
_helpers.tpl:CREATE USER→CREATE USER IF NOT EXISTSforkbdataprotection/kbprobe/kbmonitoring/proxysql, matching what_orc.tplalready does. GRANTs are already idempotent.kbadmin/kbreplicator(theselect 1;placeholder provisioning) are deliberately NOT touched here — that is a separate design question tracked in the review report (their real creation currently happens via the syncer sidecar).Render-verified with
helm template. Runtime validation before undraft: re-run accountProvision against an existing account — action must succeed instead of ERROR 1396.🤖 Generated with Claude Code